Return early for oses without ctrlBindings

Co-authored-by: David Graham <[email protected]>

Author: muan

src/index.ts

@@ -99,6 +99,7 @@ export default class Combobox {
 
 function keyboardBindings(event: KeyboardEvent, combobox: Combobox) {
   if (event.shiftKey || event.metaKey || event.altKey) return
+  if (!ctrlBindings && event.ctrlKey) return
   if (combobox.isComposing) return
 
   switch (event.key) {
@@ -132,7 +133,7 @@ function keyboardBindings(event: KeyboardEvent, combobox: Combobox) {
       }
       break
     default:
-      if (ctrlBindings && event.ctrlKey) break
+      if (event.ctrlKey) break
       combobox.clearSelection()
   }
 }

test/test.js

@@ -173,11 +173,9 @@ describe('combobox-nav', function() {
       assert.equal(options[0].getAttribute('aria-selected'), 'true')
       assert.equal(input.getAttribute('aria-activedescendant'), 'baymax')
 
-      if (ctrlBindings) {
-        press(input, 'Control', true)
-        assert.equal(options[0].getAttribute('aria-selected'), 'true', 'Selection stays on modifier keydown')
-        assert.equal(input.getAttribute('aria-activedescendant'), 'baymax', 'Selection stays on modifier keydown')
-      }
+      press(input, 'Control', true)
+      assert.equal(options[0].getAttribute('aria-selected'), 'true', 'Selection stays on modifier keydown')
+      assert.equal(input.getAttribute('aria-activedescendant'), 'baymax', 'Selection stays on modifier keydown')
 
       press(input, 'Backspace')
       assert(!list.querySelector('[aria-selected=true]'), 'Nothing should be selected')