Prevent disabled item from being committed

muan · muan · commit daaa38ee48ac · 2019-01-04T17:44:53.000-05:00
diff --git a/combobox-nav.js b/combobox-nav.js
@@ -69,7 +69,7 @@ function commitWithElement(event: MouseEvent) {
 
 function commit(input: HTMLTextAreaElement | HTMLInputElement, list: HTMLElement): boolean {
   const target = list.querySelector('[aria-selected="true"]')
-  if (!target) return false
+  if (!target || target.getAttribute('aria-disabled') === 'true') return false
   fireCommitEvent(target)
   return true
 }

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ function commitWithElement(event: MouseEvent) {`
`69`	`69`
`70`	`70`	`function commit(input: HTMLTextAreaElement \| HTMLInputElement, list: HTMLElement): boolean {`
`71`	`71`	`const target = list.querySelector('[aria-selected="true"]')`
`72`		`- if (!target) return false`
	`72`	`+ if (!target \|\| target.getAttribute('aria-disabled') === 'true') return false`
`73`	`73`	`fireCommitEvent(target)`
`74`	`74`	`return true`
`75`	`75`	`}`