Added new tests

Author: Andrew Leach

src/index.ts

@@ -97,7 +97,7 @@ export default class Combobox {
       Array.from(this.list.querySelectorAll<HTMLElement>('[role="option"]:not([aria-disabled="true"])'))
         .filter(visible)[0]
         ?.setAttribute('data-combobox-option-default', 'true')
-    } else if (this.firstOptionSelectionMode === 'selected') {
+    } else if (this.firstOptionSelectionMode === 'selected' && visible(this.list)) {
       this.navigate(1)
     }
   }
@@ -142,9 +142,7 @@ export default class Combobox {
       el.removeAttribute('aria-selected')
     }
 
-    if (this.firstOptionSelectionMode === 'active') {
-      this.indicateDefaultOption()
-    }
+    this.indicateDefaultOption()
   }
 }
 

test/test.js

@@ -285,6 +285,15 @@ describe('combobox-nav', function () {
       assert.equal(document.querySelector('[data-combobox-option-default]'), options[0])
     })
 
+    it('first item remains active when typing', () => {
+      const text = 'R2-D2'
+      for (let i = 0; i < text.length; i++) {
+        press(input, text[i])
+      }
+
+      assert.equal(document.querySelector('[data-combobox-option-default]'), options[0])
+    })
+
     it('applies default option on Enter', () => {
       let commits = 0
       document.addEventListener('combobox-commit', () => commits++)
@@ -349,6 +358,15 @@ describe('combobox-nav', function () {
       assert.equal(list.children[0].getAttribute('aria-selected'), 'true')
     })
 
+    it('first item remains selected when typing', () => {
+      const text = 'R2-D2'
+      for (let i = 0; i < text.length; i++) {
+        press(input, text[i])
+      }
+
+      assert.equal(list.children[0].getAttribute('aria-selected'), 'true')
+    })
+
     it('indicates first option when restarted', () => {
       combobox.stop()
       combobox.start()