Skip to content
This repository was archived by the owner on Sep 22, 2022. It is now read-only.

Commit 8c3b0a8

Browse files
committed
Always remove event listeners, so there won't be multiple event listeners, when the src or preload attribute changes.
1 parent 5c625a0 commit 8c3b0a8

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

index.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -235,16 +235,15 @@ class DetailsDialogElement extends HTMLElement {
235235
const state = initialized.get(this)
236236
if (!state) return
237237

238+
details.removeEventListener('toggle', loadIncludeFragment)
239+
details.removeEventListener('mouseover', loadIncludeFragment)
240+
238241
if (this.src) {
239242
details.addEventListener('toggle', loadIncludeFragment, {once: true})
240-
} else {
241-
details.removeEventListener('toggle', loadIncludeFragment)
242243
}
243244

244245
if (this.src && this.preload) {
245246
details.addEventListener('mouseover', loadIncludeFragment, {once: true})
246-
} else {
247-
details.removeEventListener('mouseover', loadIncludeFragment)
248247
}
249248
}
250249
}

0 commit comments

Comments
 (0)