Skip to content

Commit 082851d

Browse files
committed
Fix check- problem only happen because label triggers a click on input
This fix is more explicit
1 parent 7bb2d3f commit 082851d

File tree

2 files changed

+6
-16
lines changed

2 files changed

+6
-16
lines changed

index.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,8 +171,7 @@ function shouldCommit(event: Event) {
171171

172172
if (event.type === 'click') {
173173
const menuitem = target.closest('[role="menuitem"], [role="menuitemradio"]')
174-
const onlyCommitOnChangeEvent =
175-
menuitem && menuitem.getAttribute('role') === 'menuitemradio' && menuitem.querySelector('input')
174+
const onlyCommitOnChangeEvent = menuitem && menuitem.tagName === 'LABEL' && menuitem.querySelector('input')
176175
if (menuitem && !onlyCommitOnChangeEvent) {
177176
commit(menuitem, details)
178177
}

package-lock.json

Lines changed: 5 additions & 14 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)