Close popup when checked item is clicked.

We rely on change to commit the click, but change event won't happen if the item is already checked so shortcutting in that case to commit directly and close the menu.

Author: pablonete

src/index.ts

@@ -174,7 +174,10 @@ function shouldCommit(details: Element, menu: DetailsMenuElement, event: Event)
 
   if (event.type === 'click') {
     const menuitem = target.closest('[role="menuitem"], [role="menuitemradio"]')
-    const onlyCommitOnChangeEvent = menuitem && menuitem.tagName === 'LABEL' && menuitem.querySelector('input')
+    const input = menuitem?.querySelector('input')
+    // An input inside a label will be committed as a change event (we assume it's a radio input),
+    // unless the input is already checked, so we need to commit on click (to close the popup)
+    const onlyCommitOnChangeEvent = menuitem?.tagName === 'LABEL' && input && !input.checked
     if (menuitem && !onlyCommitOnChangeEvent) {
       commit(menuitem, details)
     }