Skip to content

Commit dd7d45e

Browse files
authored
Merge pull request #48 from github/ts
TypeScript conversion
2 parents 73412e2 + 98e259a commit dd7d45e

17 files changed

+1542
-4422
lines changed

.babelrc

Lines changed: 0 additions & 13 deletions
This file was deleted.

.eslintrc.json

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,10 @@
11
{
22
"extends": [
33
"plugin:github/browser",
4-
"plugin:github/es6",
5-
"plugin:github/flow"
4+
"plugin:github/recommended",
5+
"plugin:github/typescript"
66
],
77
"overrides": [
8-
{
9-
"files": "test/**/*.js",
10-
"rules": {
11-
"flowtype/require-valid-file-annotation": "off"
12-
}
13-
},
148
{
159
"files": "test/**/*.js",
1610
"excludedFiles": "test/karma.config.js",

.flowconfig

Lines changed: 0 additions & 9 deletions
This file was deleted.

.github/workflows/nodejs.yml

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
name: Node CI
2+
3+
on: push
4+
jobs:
5+
build:
6+
runs-on: ubuntu-latest
7+
steps:
8+
- uses: actions/checkout@v2
9+
- name: Use Node.js 12.x
10+
uses: actions/setup-node@v1
11+
with:
12+
node-version: 12.x
13+
- name: npm install, build, and test
14+
run: |
15+
npm install
16+
npm run build
17+
npm test
18+
env:
19+
CI: true

.travis.yml

Lines changed: 0 additions & 9 deletions
This file was deleted.

CODEOWNERS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
* @github/web-systems-reviewers

README.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,23 @@ $ npm install @github/details-menu-element
1010

1111
## Usage
1212

13+
### Script
14+
15+
Import as a module:
16+
1317
```js
1418
import '@github/details-menu-element'
1519
```
1620

21+
With a script tag:
22+
23+
```html
24+
<script type="module" src="./node_modules/@github/details-menu-element/dist/index.js">
25+
```
26+
27+
### Markup
28+
29+
1730
```html
1831
<details>
1932
<summary>Robots</summary>

examples/index.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@
6363
<script type="text/javascript">
6464
document.addEventListener('details-menu-selected', e => console.log(e))
6565
</script>
66-
<!-- <script src="../dist/index.umd.js"></script> -->
67-
<script type="text/javascript" src="https://unpkg.com/@github/details-menu-element@latest"></script>
66+
<!-- <script type="module" src="../dist/index.js"></script> -->
67+
<script type="module" src="https://unpkg.com/@github/details-menu-element@latest?module"></script>
6868
</body>
6969
</html>

index.d.ts

Lines changed: 0 additions & 13 deletions
This file was deleted.

index.js.flow

Lines changed: 0 additions & 12 deletions
This file was deleted.

0 commit comments

Comments
 (0)