Skip to content

Commit 03336fc

Browse files
authored
Fix playwright tests with experiments by manually turning off the experiments in each relevant test (#55669)
1 parent 1a96ed4 commit 03336fc

File tree

1 file changed

+15
-3
lines changed

1 file changed

+15
-3
lines changed

src/fixtures/tests/playwright-rendering.spec.ts

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import dotenv from 'dotenv'
22
import { test, expect } from '@playwright/test'
3-
import { turnOffExperimentsBeforeEach } from '../helpers/turn-off-experiments'
3+
import { turnOffExperimentsInPage } from '../helpers/turn-off-experiments'
44

55
// This exists for the benefit of local testing.
66
// In GitHub Actions, we rely on setting the environment variable directly
@@ -11,8 +11,6 @@ import { turnOffExperimentsBeforeEach } from '../helpers/turn-off-experiments'
1111
// this out.
1212
dotenv.config()
1313

14-
turnOffExperimentsBeforeEach(test)
15-
1614
const SEARCH_TESTS = !!process.env.ELASTICSEARCH_URL
1715

1816
test('view home page', async ({ page }) => {
@@ -56,6 +54,7 @@ test('do a search from home page and click on "Foo" page', async ({ page }) => {
5654
test.skip(!SEARCH_TESTS, 'No local Elasticsearch, no tests involving search')
5755

5856
await page.goto('/')
57+
await turnOffExperimentsInPage(page)
5958
await page.getByTestId('site-search-input').click()
6059
await page.getByTestId('site-search-input').fill('serve playwright')
6160
await page.keyboard.press('Enter')
@@ -186,6 +185,7 @@ test('search from enterprise-cloud and filter by top-level Fooing', async ({ pag
186185
test.skip(!SEARCH_TESTS, 'No local Elasticsearch, no tests involving search')
187186

188187
await page.goto('/enterprise-cloud@latest')
188+
await turnOffExperimentsInPage(page)
189189

190190
await page.getByTestId('site-search-input').fill('fixture')
191191
await page.getByTestId('site-search-input').press('Enter')
@@ -200,6 +200,7 @@ test('search from enterprise-cloud and filter by top-level Fooing', async ({ pag
200200
test.describe('platform picker', () => {
201201
test('switch operating systems', async ({ page }) => {
202202
await page.goto('/get-started/liquid/platform-specific')
203+
await turnOffExperimentsInPage(page)
203204

204205
await page.getByTestId('platform-picker').getByRole('link', { name: 'Mac' }).click()
205206
await expect(page).toHaveURL(/\?platform=mac/)
@@ -215,6 +216,7 @@ test.describe('platform picker', () => {
215216
test('minitoc matches picker', async ({ page }) => {
216217
// default platform set to windows in fixture fronmatter
217218
await page.goto('/get-started/liquid/platform-specific')
219+
await turnOffExperimentsInPage(page)
218220
await expect(
219221
page.getByTestId('minitoc').getByRole('link', { name: 'Macintosh until 1999' }),
220222
).not.toBeVisible()
@@ -232,6 +234,7 @@ test.describe('platform picker', () => {
232234

233235
test('remember last clicked OS', async ({ page }) => {
234236
await page.goto('/get-started/liquid/platform-specific')
237+
await turnOffExperimentsInPage(page)
235238
await page.getByTestId('platform-picker').getByRole('link', { name: 'Windows' }).click()
236239

237240
// Return and now the cookie should start us off on Windows again
@@ -244,6 +247,7 @@ test.describe('platform picker', () => {
244247
test.describe('tool picker', () => {
245248
test('switch tools', async ({ page }) => {
246249
await page.goto('/get-started/liquid/tool-specific')
250+
await turnOffExperimentsInPage(page)
247251

248252
await page.getByTestId('tool-picker').getByRole('link', { name: 'GitHub CLI' }).click()
249253
await expect(page).toHaveURL(/\?tool=cli/)
@@ -268,6 +272,7 @@ test.describe('tool picker', () => {
268272

269273
test('remember last clicked tool', async ({ page }) => {
270274
await page.goto('/get-started/liquid/tool-specific')
275+
await turnOffExperimentsInPage(page)
271276
await page.getByTestId('tool-picker').getByRole('link', { name: 'Web browser' }).click()
272277

273278
// Return and now the cookie should start us off with Web UI content again
@@ -280,6 +285,7 @@ test.describe('tool picker', () => {
280285
test('minitoc matches picker', async ({ page }) => {
281286
// default tool set to desktop in fixture fronmatter
282287
await page.goto('/get-started/liquid/tool-specific')
288+
await turnOffExperimentsInPage(page)
283289
await expect(
284290
page.getByTestId('minitoc').getByRole('link', { name: 'Desktop section' }),
285291
).toBeVisible()
@@ -313,6 +319,7 @@ test('navigate with side bar into article inside a map-topic inside a category',
313319
test.describe('hover cards', () => {
314320
test('hover over link', async ({ page }) => {
315321
await page.goto('/pages/quickstart')
322+
await turnOffExperimentsInPage(page)
316323

317324
// hover over a link and check for intro content from hovercard
318325
await page
@@ -374,6 +381,7 @@ test.describe('hover cards', () => {
374381

375382
test('use keyboard shortcut to open hover card', async ({ page }) => {
376383
await page.goto('/pages/quickstart')
384+
await turnOffExperimentsInPage(page)
377385

378386
// Simply putting focus on the link should not open the hovercard
379387
await page
@@ -405,6 +413,7 @@ test.describe('hover cards', () => {
405413

406414
test('able to use Esc to close hovercard', async ({ page }) => {
407415
await page.goto('/pages/quickstart')
416+
await turnOffExperimentsInPage(page)
408417

409418
// hover over a link and check for intro content from hovercard
410419
await page
@@ -564,6 +573,7 @@ test.describe('test nav at different viewports', () => {
564573
height: 700,
565574
})
566575
await page.goto('/get-started/foo/bar')
576+
await turnOffExperimentsInPage(page)
567577

568578
// header sign-up button is not visible
569579
await expect(page.getByTestId('header-signup')).not.toBeVisible()
@@ -603,6 +613,7 @@ test.describe('test nav at different viewports', () => {
603613
height: 700,
604614
})
605615
await page.goto('/get-started/foo/bar')
616+
await turnOffExperimentsInPage(page)
606617
await page.getByRole('button', { name: 'Open Search Bar' }).click()
607618
await page.getByTestId('site-search-input').click()
608619
await page.getByTestId('site-search-input').fill('serve playwright')
@@ -619,6 +630,7 @@ test.describe('test nav at different viewports', () => {
619630
height: 700,
620631
})
621632
await page.goto('/get-started/foo/bar')
633+
await turnOffExperimentsInPage(page)
622634
await page.getByTestId('site-search-input').click()
623635
await page.getByTestId('site-search-input').fill('serve playwright')
624636
await page.getByTestId('site-search-input').press('Enter')

0 commit comments

Comments
 (0)