Skip to content

Commit 1d5ab6d

Browse files
authored
Merge pull request #38974 from github/repo-sync
Repo sync
2 parents 2acc813 + 6817fb0 commit 1d5ab6d

File tree

7 files changed

+225
-220
lines changed

7 files changed

+225
-220
lines changed

content/actions/hosting-your-own-runners/managing-self-hosted-runners-with-actions-runner-controller/troubleshooting-actions-runner-controller-errors.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,10 @@ To fix this, you can do one of the following things.
150150

151151
A `401 Unauthorized` error when attempting to obtain an access token for a {% data variables.product.prodname_github_app %} could be a result of a Network Time Protocol (NTP) drift. Ensure that your Kubernetes system is accurately syncing with an NTP server and that there isn't a significant time drift. There is more leeway if your system time is behind {% data variables.product.github %}'s time, but if the environment is more than a few seconds ahead, 401 errors will occur when using {% data variables.product.prodname_github_app %}.
152152

153+
## Runner group limits
154+
155+
{% data reusables.actions.self-hosted-runner-group-limit %}
156+
153157
## Legal notice
154158

155159
{% data reusables.actions.actions-runner-controller-legal-notice %}

content/actions/hosting-your-own-runners/managing-self-hosted-runners/usage-limits-for-self-hosted-runners.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,4 @@ type: overview
1515
{% data reusables.actions.usage-api-requests %}
1616
* **Job matrix** - {% data reusables.actions.usage-matrix-limits %}
1717
{% data reusables.actions.usage-workflow-queue-limits %}
18-
* **Registering self-hosted runners** - You can have a maximum of 10,000 self-hosted runners in one runner group. If this limit is reached, adding a new runner will not be possible.
18+
* **Registering self-hosted runners** - {% data reusables.actions.self-hosted-runner-group-limit %}
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
You can have a maximum of 10,000 self-hosted runners in one runner group. If this limit is reached, adding a new runner will not be possible.

src/rest/data/ghes-3.15-2022-11-28/schema.json

Lines changed: 144 additions & 144 deletions
Large diffs are not rendered by default.

src/rest/data/ghes-3.17-2022-11-28/schema.json

Lines changed: 72 additions & 72 deletions
Large diffs are not rendered by default.

src/search/middleware/search-routes.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ router.get(
8888

8989
if (process.env.NODE_ENV !== 'development') {
9090
searchCacheControl(res)
91-
setFastlySurrogateKey(res, SURROGATE_ENUMS.MANUAL)
91+
setFastlySurrogateKey(res, SURROGATE_ENUMS.DEFAULT)
9292
}
9393

9494
res.status(200).json({ meta, hits })

src/search/tests/api-ai-search-autocomplete.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ const getSearchEndpointWithParams = (searchParams: URLSearchParams) =>
3333
describeIfElasticsearchURL('search/ai-search-autocomplete v1 middleware', () => {
3434
vi.setConfig({ testTimeout: 60 * 1000 })
3535

36-
test('basic search', async () => {
36+
test('perform a basic ai autocomplete search', async () => {
3737
const sp = new URLSearchParams()
3838
// To see why this will work,
3939
// see src/search/tests/fixtures/data/ai/*
@@ -59,7 +59,7 @@ describeIfElasticsearchURL('search/ai-search-autocomplete v1 middleware', () =>
5959
expect(res.headers['cache-control']).toMatch(/max-age=[1-9]/)
6060
expect(res.headers['surrogate-control']).toContain('public')
6161
expect(res.headers['surrogate-control']).toMatch(/max-age=[1-9]/)
62-
expect(res.headers['surrogate-key']).toBe('manual-purge')
62+
expect(res.headers['surrogate-key']).toBe('every-deployment')
6363
})
6464

6565
test('invalid version', async () => {

0 commit comments

Comments
 (0)