Cleanup TODOs and implement English fallbacks for learning tracks (#58767)

Co-authored-by: Copilot <[email protected]>

Author: heiskr

src/content-linter/lib/linting-rules/image-file-kebab-case.ts

@@ -18,7 +18,7 @@ export const imageFileKebabCase = {
           suggestedFileName,
           imageFileName,
           [token.line.indexOf(imageFileName) + 1, imageFileName.length],
-          null, // Todo add fix
+          null,
         )
       }
     })

src/deployments/production/README.md

@@ -1,6 +1,6 @@
 # Production deploys
 
-For internal Docs relating to our production deploys see [TODO Docs-Engineering URL]
+
 
 ## Auto deploys
 

src/landings/components/ProductGuidesContext.tsx

@@ -7,7 +7,7 @@ export type LearningTrack = {
   trackProduct: string
   title: string
   description: string
-  guides?: Array<{ href: string; page?: { type: string }; title: string; intro: string }>
+  guides?: Array<{ href: string; type: string | null; title: string; intro: string }>
 }
 
 export type ArticleGuide = {
@@ -60,7 +60,7 @@ export const getProductGuidesContextFromRequest = (req: ExtendedRequest): Produc
           title: (guide.title as string) || '',
           intro: (guide.intro as string) || '',
           href: (guide.href as string) || '',
-          page: guide.page as { type: string } | undefined,
+          type: ((guide.page as any)?.type as string) || null,
         }),
       ),
     }),

src/learning-track/components/guides/LearningTrack.tsx

@@ -31,9 +31,7 @@ export const LearningTrack = ({ track }: Props) => {
         <ol className="pl-4 my-3 f4">
           {track.guides.map((guide) => (
             <li key={guide.href + track.trackName}>
-              <span className="mr-2">
-                {tObject('guide_types')[guide.page?.type || ''] as string}
-              </span>
+              <span className="mr-2">{tObject('guide_types')[guide.type || ''] as string}</span>
               <Link
                 href={`${guide.href}?learn=${track.trackName}&learnProduct=${track.trackProduct}`}
                 className="text-underline"

src/learning-track/lib/get-link-data.ts

@@ -52,7 +52,7 @@ async function processLink(
     ? await executeWithFallback(
         context,
         () => renderContent(linkHref, context, opts),
-        () => '', // todo get english linkHref
+        (enContext: Context) => renderContent(linkHref, enContext, opts),
       )
     : linkHref
   // If the link was `{% ifversion ghes %}/admin/foo/bar{% endifversion %}`

src/learning-track/lib/process-learning-tracks.ts

@@ -25,7 +25,7 @@ export default async function processLearningTracks(
       ? await executeWithFallback(
           context,
           () => renderContent(rawTrackName, context, renderOpts),
-          () => '', // todo use english rawTrackName
+          (enContext: Context) => renderContent(rawTrackName, enContext, renderOpts),
         )
       : rawTrackName
     if (!renderedTrackName) continue

src/learning-track/middleware/learning-track.ts

@@ -86,7 +86,17 @@ export default async function learningTrack(
   const trackTitle = await executeWithFallback(
     req.context,
     () => renderContent(track.title, req.context, renderOpts),
-    () => '', // todo use english track.title
+    (enContext: Context) => {
+      const allEnglishLearningTracks = getDeepDataByLanguage(
+        'learning-tracks',
+        'en',
+      ) as LearningTracks
+      const enTrack = allEnglishLearningTracks[trackProduct]?.[trackName]
+      if (!enTrack) {
+        throw new Error(`English learning track not found: ${trackProduct}.${trackName}`)
+      }
+      return renderContent(enTrack.title, enContext, renderOpts)
+    },
   )
 
   const currentLearningTrack: CurrentLearningTrack = { trackName, trackProduct, trackTitle }
@@ -176,7 +186,7 @@ async function indexOfLearningTrackGuide(
     const renderedGuidePath = await executeWithFallback(
       context,
       () => renderContent(trackGuidePaths[i], context, renderOpts),
-      () => '', // todo use english trackGuidePaths[i]
+      (enContext: Context) => renderContent(trackGuidePaths[i], enContext, renderOpts),
     )
 
     if (!renderedGuidePath) continue

src/pages/README.md

@@ -140,4 +140,3 @@ npm run dev
 ```
 
 Routes should load without errors and render correct content from subject directories.
-

src/shielding/tests/shielding.ts

@@ -71,7 +71,6 @@ describe('index.md and .md suffixes', () => {
     }
   })
 
-  // TODO-ARTICLEAPI: unskip tests or replace when ready to ship article API
   test('any URL that ends with /.md redirects', async () => {
     // With language prefix
     {