Skip to content

Commit 22c3b9e

Browse files
authored
Add is_headless as a field instead of filter (#55483)
1 parent 4cecc07 commit 22c3b9e

File tree

4 files changed

+7
-2
lines changed

4 files changed

+7
-2
lines changed

src/events/components/events.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,6 @@ export function sendEvent<T extends EventType>({
8686
eventGroupKey?: string
8787
eventGroupId?: string
8888
} & EventPropsByType[T]) {
89-
if (isHeadless()) return
90-
9189
const body = {
9290
type,
9391

@@ -118,6 +116,7 @@ export function sendEvent<T extends EventType>({
118116
// Device information
119117
// os, os_version, browser, browser_version:
120118
...parseUserAgent(),
119+
is_headless: isHeadless(),
121120
viewport_width: document.documentElement.clientWidth,
122121
viewport_height: document.documentElement.clientHeight,
123122

src/events/lib/schema.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,9 @@ const context = {
136136
type: 'string',
137137
description: 'The version of the browser the user is browsing with.',
138138
},
139+
is_headless: {
140+
type: 'boolean',
141+
},
139142
viewport_width: {
140143
type: 'number',
141144
description: 'The viewport width, not the overall device size.',

src/events/tests/middleware.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ describe('POST /events', () => {
4141
os_version: '18.04',
4242
browser: 'chrome',
4343
browser_version: '85.0.4183.121',
44+
is_headless: false,
4445
viewport_width: 1418,
4546
viewport_height: 501,
4647

@@ -72,6 +73,7 @@ describe('POST /events', () => {
7273
os_version: '18.04',
7374
browser: 'chrome',
7475
browser_version: '85.0.4183.121',
76+
is_headless: false,
7577
viewport_width: 1418,
7678
viewport_height: 501,
7779

src/events/types.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ export type EventProps = {
5050
code_display_preference: string
5151
event_group_key?: string
5252
event_group_id?: string
53+
is_headless: boolean
5354
}
5455
}
5556

0 commit comments

Comments
 (0)