cleanup old search, add tests for new search (#56533)

Co-authored-by: Copilot <[email protected]>

Author: Ebonsignori

src/events/components/experiments/experiments.ts

@@ -15,20 +15,19 @@ type Experiment = {
 }
 
 // Update this with the name of the experiment, e.g. | 'example_experiment'
-export type ExperimentNames = 'ai_search_experiment'
+export type ExperimentNames = 'placeholder_experiment'
 
 export const EXPERIMENTS = {
-  ai_search_experiment: {
-    key: 'ai_search_experiment',
-    isActive: true, // Set to false when the experiment is over
-    // We still use an experiment for the AI Search until we:
-    // 1. Move analytics over the main dashboard
-    // 2. Don't require an emergency rollback, which experiments provides us
-    percentOfUsersToGetExperiment: 100, // 100% of users will get the experiment
-    includeVariationInContext: true, // All events will include the `experiment_variation` of the `ai_search_experiment`
-    limitToLanguages: ['en'], // Only users with the `en` language will be included in the experiment
-    alwaysShowForStaff: true, // When set to true, staff will always see the experiment (determined by the `staffonly` cookie)
-    turnOnWithURLParam: 'ai_search', /// When the query param `?feature=ai_search` is set, the experiment will be enabled
+  // Placeholder experiment to maintain type compatibility
+  placeholder_experiment: {
+    key: 'placeholder_experiment',
+    isActive: false, // Inactive placeholder
+    percentOfUsersToGetExperiment: 0,
+    includeVariationInContext: false,
+    limitToLanguages: [],
+    limitToVersions: [],
+    alwaysShowForStaff: false,
+    turnOnWithURLParam: 'placeholder', // Placeholder URL param
   },
   /*  Add new experiments here, example:
   'example_experiment': {

src/fixtures/helpers/turn-off-experiments.ts

@@ -44,3 +44,18 @@ export function turnOffExperimentsBeforeEach(test: typeof Test) {
     await turnOffExperimentsInPage(page)
   })
 }
+
+export async function dismissCTAPopover(page: Page) {
+  // Set the CTA popover to permanently dismissed in localStorage
+  await page.evaluate(() => {
+    localStorage.setItem(
+      'ctaPopoverState',
+      JSON.stringify({
+        dismissedCount: 0,
+        lastDismissedAt: null,
+        permanentlyDismissed: true,
+      }),
+    )
+  })
+  await page.reload()
+}

src/fixtures/tests/playwright-local-dev.spec.ts

@@ -12,38 +12,49 @@
  */
 
 import { test, expect } from '@playwright/test'
-import { turnOffExperimentsInPage } from '../helpers/turn-off-experiments'
+import { dismissCTAPopover, turnOffExperimentsInPage } from '../helpers/turn-off-experiments'
 
 const TEST_EARLY_ACCESS = Boolean(JSON.parse(process.env.TEST_EARLY_ACCESS || 'false'))
 
 test('view home page', async ({ page }) => {
   await page.goto('/')
   await turnOffExperimentsInPage(page)
+  await dismissCTAPopover(page)
+
   await expect(page).toHaveTitle(/GitHub Docs/)
 })
 
 test('click "Get started" from home page', async ({ page }) => {
   await page.goto('/')
   await turnOffExperimentsInPage(page)
+  await dismissCTAPopover(page)
+
   await page.getByRole('link', { name: 'Get started' }).click()
   await expect(page).toHaveTitle(/Get started with GitHub/)
   await expect(page).toHaveURL(/\/en\/get-started/)
 })
 
-test('search "git" and get results', async ({ page }) => {
+test('search "foo" and get results', async ({ page }) => {
   await page.goto('/')
   await turnOffExperimentsInPage(page)
-  await page.getByTestId('site-search-input').click()
-  await page.getByTestId('site-search-input').fill('git')
-  await page.getByTestId('site-search-input').press('Enter')
-  await expect(page.getByRole('heading', { name: /\d+ Search results for "git"/ })).toBeVisible()
+  await dismissCTAPopover(page)
+
+  await page.locator('[data-testid="search"]:visible').click()
+  await page.getByTestId('overlay-search-input').fill('foo')
+  // Wait for search results to load
+  await page.waitForTimeout(1000)
+  // Click "View more results" to get to the search page
+  await page.getByText('View more results').click()
+  await expect(page.getByRole('heading', { name: /\d+ Search results for "foo"/ })).toBeVisible()
 })
 
 test('view the early-access links page', async ({ page }) => {
   if (!TEST_EARLY_ACCESS) return
 
   await page.goto('/early-access')
   await turnOffExperimentsInPage(page)
+  await dismissCTAPopover(page)
+
   await expect(page).toHaveURL(/\/en\/early-access/)
   await page.getByRole('heading', { name: 'Early Access documentation', level: 1 }).click()
   const links = await page.$$eval(