Merge pull request #36023 from github/repo-sync

Repo sync

Author: docs-bot

src/frame/middleware/index.ts

@@ -113,7 +113,7 @@ export default function (app: Express) {
   }
 
   // *** Observability ***
-  if (process.env.MODA_PROD_SERVICE_ENV) {
+  if (process.env.MODA_PROD_SERVICE_ENV === 'true') {
     app.use(datadog)
   }
 

src/observability/lib/statsd.js

@@ -9,7 +9,7 @@ const {
   DD_AGENT_HOST,
 } = process.env
 
-const mock = NODE_ENV === 'test' || !MODA_PROD_SERVICE_ENV
+const mock = NODE_ENV === 'test' || MODA_PROD_SERVICE_ENV !== 'true'
 
 // MODA_APP_NAME gets set when the deploy target is Moda
 const modaApp = MODA_APP_NAME ? `moda_app_name:${MODA_APP_NAME}` : false

src/observability/middleware/trigger-error.ts

@@ -15,7 +15,8 @@ export default async function triggerError(
   // pattern used on async middleware! This is an intentional omission!
 
   // prevent this from being used in production
-  if (process.env.NODE_ENV === 'production' && process.env.MODA_PROD_SERVICE_ENV) return next()
+  if (process.env.NODE_ENV === 'production' && process.env.MODA_PROD_SERVICE_ENV === 'true')
+    return next()
 
   throw new Error('Intentional error')
 }