find orphaned features: use Number() instead of parseFloat() (#50024)

rsese · Peter Bengtsson · web-flow · commit 538dcc249c60 · 2024-04-08T16:35:04.000Z
Co-authored-by: Peter Bengtsson &lt;peterbe@github.com&gt;
diff --git a/src/data-directory/scripts/find-orphaned-features/find.ts b/src/data-directory/scripts/find-orphaned-features/find.ts
@@ -27,6 +27,7 @@
  *
  */
 
+import { strictEqual } from 'node:assert'
 import fs from 'fs'
 import path from 'path'
 
@@ -296,5 +297,9 @@ function escapeRegex(string: string) {
 }
 
 function isFloat(x: any) {
-  return !!(parseFloat(x) + 1)
+  return !!(Number(x) + 1)
 }
+strictEqual(isFloat('1.2'), true)
+strictEqual(isFloat('10'), true)
+strictEqual(isFloat('notatall'), false)
+strictEqual(isFloat('2fa'), false)

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,7 @@`
`27`	`27`	`*`
`28`	`28`	`*/`
`29`	`29`
	`30`	`+import { strictEqual } from 'node:assert'`
`30`	`31`	`import fs from 'fs'`
`31`	`32`	`import path from 'path'`
`32`	`33`
`@@ -296,5 +297,9 @@ function escapeRegex(string: string) {`
`296`	`297`	`}`
`297`	`298`
`298`	`299`	`function isFloat(x: any) {`
`299`		`- return !!(parseFloat(x) + 1)`
	`300`	`+ return !!(Number(x) + 1)`
`300`	`301`	`}`
	`302`	`+strictEqual(isFloat('1.2'), true)`
	`303`	`+strictEqual(isFloat('10'), true)`
	`304`	`+strictEqual(isFloat('notatall'), false)`
	`305`	`+strictEqual(isFloat('2fa'), false)`