better aria labels (#55929)

Author: Ebonsignori

data/ui.yml

@@ -30,6 +30,7 @@ search:
     placeholder_no_icon: Search or ask Copilot
     shortcut: Type {{icon}} to search
   overlay:
+    aria_label: Search overlay
     input_aria_label: Search or ask Copilot
     suggestions_list_aria_label: Search suggestions
     ai_suggestions_list_aria_label: Copilot search suggestions

src/fixtures/fixtures/data/ui.yml

@@ -30,6 +30,7 @@ search:
     placeholder_no_icon: Search or ask Copilot
     shortcut: Type {{icon}} to search
   overlay:
+    aria_label: Search overlay
     input_aria_label: Search or ask Copilot
     suggestions_list_aria_label: Search suggestions
     ai_suggestions_list_aria_label: Copilot search suggestions

src/search/components/input/SearchOverlay.tsx

@@ -675,7 +675,6 @@ export function SearchOverlay({
     )
   }
 
-  const overlayHeadingId = 'overlay-heading'
   return (
     <>
       <div className={styles.overlayBackdrop} />
@@ -698,7 +697,7 @@ export function SearchOverlay({
         }
         role="dialog"
         aria-modal="true"
-        aria-labelledby={overlayHeadingId}
+        aria-label={t('search.overlay.aria_label')}
         ref={overlayRef}
       >
         <div className={styles.header}>
@@ -723,11 +722,11 @@ export function SearchOverlay({
             value={urlSearchInputQuery}
             onChange={handleSearchQueryChange}
             leadingVisual={<SearchIcon />}
-            aria-labelledby={overlayHeadingId}
             role="combobox"
             // In AskAI the search input not longer "controls" the suggestions list, because there is no list, so we remove the aria-controls attribute
             aria-controls={isAskAIState ? 'ask-ai-result-container' : 'search-suggestions-list'}
             aria-expanded={combinedOptions.length > 0}
+            aria-label={t('search.overlay.input_aria_label')}
             aria-activedescendant={
               selectedIndex >= 0
                 ? `search-option-${combinedOptions[selectedIndex]?.group}-${selectedIndex}`