Add content linter rule to prevent not with feature-based versions (#56679)

Author: heiskr

src/content-linter/lib/linting-rules/liquid-versioning.js

@@ -133,9 +133,14 @@ function validateIfversionConditionals(cond, possibleVersionNames) {
     if (strParts.length === 2) {
       const [notKeyword, version] = strParts
       const isValidVersion = validateVersion(version)
-      const isValid = notKeyword === 'not' && isValidVersion
-      if (!isValid) {
+      const isFeatureBasedVersion = Object.keys(getAllFeatures()).includes(version)
+
+      if (notKeyword !== 'not' || !isValidVersion) {
         errors.push(`"${cond}" is not a valid conditional`)
+      } else if (isFeatureBasedVersion) {
+        errors.push(
+          `"${cond}" is not valid - the 'not' keyword cannot be used with feature-based version "${version}"`,
+        )
       }
     }
 

src/content-linter/tests/unit/liquid-versioning.js

@@ -94,4 +94,29 @@ describe(liquidIfVersionTags.names.join(' - '), () => {
     const errors = result.markdown
     expect(errors.length).toBe(0)
   })
+
+  test('ifversion tags with not keyword and feature-based versions fail', async () => {
+    const markdown = [
+      '{% ifversion not volvo %}',
+      '{% ifversion fpt or not volvo %}',
+      '{% ifversion not them-and-all %}',
+    ]
+    const result = await runRule(liquidIfVersionTags, {
+      strings: { markdown: markdown.join('\n') },
+    })
+    const errors = result.markdown
+    expect(errors.length).toBe(markdown.length)
+    expect(errors.every((error) => error.errorDetail.includes('feature-based version'))).toBe(true)
+  })
+
+  test('ifversion tags with not keyword and short versions pass', async () => {
+    const markdown = [
+      '{% ifversion not ghec %}',
+      '{% ifversion fpt or not ghes %}',
+      '{% ifversion not fpt %}',
+    ].join('\n')
+    const result = await runRule(liquidIfVersionTags, { strings: { markdown } })
+    const errors = result.markdown
+    expect(errors.length).toBe(0)
+  })
 })