Remove app level rate limiter, adjust moda config with comments for future reference (#55209)

Author: heiskr

config/kubernetes/production/deployments/webapp.yaml

@@ -23,8 +23,15 @@ spec:
           image: docs-internal
           resources:
             requests:
-              cpu: 8000m
-              memory: 10Gi
+              cpu: 4000m
+              # Absolute minimum to start app is 1000m
+              # Node is single-threaded but we want more CPUs
+              # for OS and image resizing, and other binary executions
+              # Better to increase replicas or memory than CPU
+              memory: 8Gi
+              # Absolute minimum to start app is 4500Mi
+              # Would increase with more pages, versions, or languages supported
+              # The additional memory helps during traffic surges
             limits:
               cpu: 16000m
               memory: 16Gi

package-lock.json

@@ -268,7 +268,6 @@
     "dotenv": "^16.4.5",
     "escape-string-regexp": "5.0.0",
     "express": "4.21.2",
-    "express-rate-limit": "7.4.0",
     "fastest-levenshtein": "1.0.16",
     "file-type": "20.0.0",
     "flat": "^6.0.1",

package.json

@@ -6,11 +6,9 @@ import handleOldNextDataPaths from './handle-old-next-data-paths'
 import handleInvalidQuerystringValues from './handle-invalid-query-string-values'
 import handleInvalidNextPaths from './handle-invalid-nextjs-paths'
 import handleInvalidHeaders from './handle-invalid-headers'
-import { createRateLimiter } from './rate-limit'
 
 const router = express.Router()
 
-router.use(createRateLimiter())
 router.use(handleInvalidQuerystrings)
 router.use(handleInvalidPaths)
 router.use(handleOldNextDataPaths)