Remove unused env vars from Azure (#54036)

Author: rachmari

src/frame/middleware/index.ts

@@ -113,11 +113,7 @@ export default function (app: Express) {
   }
 
   // *** Observability ***
-  // This DD_API_KEY is only being used to determine if the target
-  // deployment environment is production. The key is not actually
-  // used for sending data. Afer migrating to Moda, we can remove
-  // the DD_API_KEY.
-  if (process.env.DD_API_KEY || process.env.MODA_PROD_SERVICE_ENV) {
+  if (process.env.MODA_PROD_SERVICE_ENV) {
     app.use(datadog)
   }
 

src/observability/lib/statsd.js

@@ -1,29 +1,20 @@
 import StatsD from 'hot-shots'
 
 const {
-  HEROKU_APP_NAME,
   NODE_ENV,
-  DD_API_KEY,
   MODA_APP_NAME,
   MODA_PROD_SERVICE_ENV,
   KUBE_NODE_HOSTNAME,
   DD_DOGSTATSD_PORT,
   DD_AGENT_HOST,
 } = process.env
 
-// This DD_API_KEY is only being used to determine if the target
-// deployment environment is production. The key is not actually
-// used for sending data. Afer migrating to Moda, we can remove
-// the DD_API_KEY.
-const isServiceEnvProduction = DD_API_KEY || MODA_PROD_SERVICE_ENV
-const mock = NODE_ENV === 'test' || !isServiceEnvProduction
+const mock = NODE_ENV === 'test' || !MODA_PROD_SERVICE_ENV
 
 // MODA_APP_NAME gets set when the deploy target is Moda
 const modaApp = MODA_APP_NAME ? `moda_app_name:${MODA_APP_NAME}` : false
-// HEROKU_APP_NAME gets set when the deploy target is Azure
-const herokuApp = HEROKU_APP_NAME ? `heroku_app:${HEROKU_APP_NAME}` : false
 
-export const tags = ['app:docs', modaApp, herokuApp].filter(Boolean)
+export const tags = ['app:docs', modaApp].filter(Boolean)
 
 /**
  * @type {import('hot-shots').StatsD}

src/observability/middleware/handle-errors.ts

@@ -110,7 +110,7 @@ export default async function handleError(
     }
 
     // display error on the page in development and staging, but not in production
-    if (process.env.HEROKU_PRODUCTION_APP !== 'true') {
+    if (!process.env.MODA_PROD_SERVICE_ENV) {
       req.context.error = error
     }
 

src/observability/middleware/trigger-error.ts

@@ -15,7 +15,7 @@ export default async function triggerError(
   // pattern used on async middleware! This is an intentional omission!
 
   // prevent this from being used in production
-  if (process.env.NODE_ENV === 'production' && process.env.HEROKU_PRODUCTION_APP) return next()
+  if (process.env.NODE_ENV === 'production' && process.env.MODA_PROD_SERVICE_ENV) return next()
 
   throw new Error('Intentional error')
 }