Skip to content

Commit c86be62

Browse files
felicitymayvgrl
andauthored
Hack week 2025: Fix warnings in authentication and billing folders (#53930)
Co-authored-by: Vanessa <[email protected]>
1 parent 6f8c1dd commit c86be62

File tree

7 files changed

+9
-30
lines changed

7 files changed

+9
-30
lines changed

content/authentication/keeping-your-account-and-data-secure/sudo-mode.md

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -42,19 +42,17 @@ After you authenticate to perform a sensitive action, your session is temporaril
4242

4343
## Confirming access for sudo mode
4444

45-
To confirm access for sudo mode, you {% ifversion totp-and-mobile-sudo-challenge %}can{% else %}must{% endif %} authenticate with your password.{% ifversion totp-and-mobile-sudo-challenge %} Optionally, you can use a different authentication method, like {% ifversion passkeys %}a passkey, {% endif %}{% ifversion fpt or ghec %}a security key, {% data variables.product.prodname_mobile %}, or a 2FA code{% elsif ghes %}a security key or a 2FA code{% endif %}.{% endif %}
45+
To confirm access for sudo mode, you can authenticate with your password. Optionally, you can use a different authentication method, like {% ifversion passkeys %}a passkey, {% endif %}{% ifversion fpt or ghec %}a security key, {% data variables.product.prodname_mobile %}, or a 2FA code{% elsif ghes %}a security key or a 2FA code{% endif %}.
4646

4747
{%- ifversion passkeys %}
4848
* [Confirming access using a passkey key](#confirming-access-using-a-passkey)
4949
{%- endif %}
50-
{%- ifversion totp-and-mobile-sudo-challenge %}
5150
* [Confirming access using a security key](#confirming-access-using-a-security-key)
5251
{%- ifversion fpt or ghec %}
5352
* [Confirming access using GitHub Mobile](#confirming-access-using-github-mobile)
5453
{%- endif %}
5554
* [Confirming access using a 2FA code](#confirming-access-using-a-2fa-code)
5655
* [Confirming access using your password](#confirming-access-using-your-password)
57-
{%- endif %}
5856

5957
{% ifversion passkeys %}
6058

@@ -63,8 +61,6 @@ To confirm access for sudo mode, you {% ifversion totp-and-mobile-sudo-challenge
6361
You must have a passkey registered to your account to confirm access to your account for sudo mode using a passkey. See [AUTOTITLE](/authentication/authenticating-with-a-passkey/about-passkeys).
6462
{% endif %}
6563

66-
{% ifversion totp-and-mobile-sudo-challenge %}
67-
6864
### Confirming access using a security key
6965

7066
You must configure two-factor authentication (2FA) for your account using a security key to confirm access to your account for sudo mode using the security key. For more information, see [AUTOTITLE](/authentication/securing-your-account-with-two-factor-authentication-2fa/configuring-two-factor-authentication#configuring-two-factor-authentication-using-a-security-key).
@@ -94,6 +90,4 @@ When prompted to authenticate for sudo mode, type the authentication code from y
9490

9591
### Confirming access using your password
9692

97-
{% endif %}
98-
9993
When prompted to authenticate for sudo mode, type your password, then click **Confirm**.

content/authentication/managing-commit-signature-verification/adding-a-gpg-key-to-your-github-account.md

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,9 @@ To sign commits associated with your account on {% data variables.product.produc
2626

2727
You can add multiple public keys to your account on {% data variables.product.product_name %}. Commits signed by any of the corresponding private keys will show as verified. {% ifversion persistent-commit-verification %}Once a commit has been verified, any commits signed by the corresponding private key will continue to show as verified, even if the public key is removed.{% else %}If you remove a public key, any commits signed by the corresponding private key will no longer show as verified.{% endif %}
2828

29-
![Screenshot of a list of commits. One commit is marked with a "Verified" label. Next to the label, a dropdown explains that the commit was signed and shows a timestamp of when it was signed.](/assets/images/help/settings/verified-persistent-commit.png)
29+
![Screenshot of a list of commits. One commit is marked as "Verified." A dropdown shows the commit was signed and when it was signed.](/assets/images/help/settings/verified-persistent-commit.png)
3030

31-
{% ifversion upload-expired-or-revoked-gpg-key %}
32-
To verify as many of your commits as possible, you can add expired and revoked keys. If the key meets all other verification requirements, commits that were previously signed by any of the corresponding private keys will show as verified and indicate that their signing key is expired or revoked.{% endif %}
31+
To verify as many of your commits as possible, you can add expired and revoked keys. If the key meets all other verification requirements, commits that were previously signed by any of the corresponding private keys will show as verified and indicate that their signing key is expired or revoked.
3332

3433
{% data reusables.gpg.supported-gpg-key-algorithms %}
3534

@@ -45,20 +44,6 @@ When verifying a signature, {% data variables.product.product_name %} extracts t
4544
1. Click **Add GPG key**.
4645
1. If prompted, authenticate to your {% data variables.product.prodname_dotcom %} account to confirm the action.
4746

48-
{% ifversion upload-expired-or-revoked-gpg-key %}
49-
{% else %}
50-
51-
## Updating an expired GPG key
52-
53-
When verifying a signature, {% data variables.product.product_name %} checks that the key is not revoked or expired. If your signing key is revoked or expired, {% data variables.product.product_name %} cannot verify your signatures.
54-
55-
If your key is expired, you must [update its expiration](https://www.gnupg.org/gph/en/manual.html#AEN329), export the new key, delete the expired key in your account on {% data variables.product.product_name %}, and add the new key to your account as described above. Your previous commits and tags will show as verified, as long as the key meets all other verification requirements.
56-
57-
If your key is revoked, use the primary key or another key that is not revoked to sign your commits.
58-
59-
If your key is invalid and you don't use another valid key in your key set, but instead generate a new GPG key with a new set of credentials, then your commits made with the revoked or expired key will continue to show as unverified. Also, your new credentials will not be able to re-sign or verify your old commits and tags.
60-
{% endif %}
61-
6247
## Further reading
6348

6449
* [AUTOTITLE](/authentication/managing-commit-signature-verification/checking-for-existing-gpg-keys)

content/billing/managing-billing-for-your-products/managing-billing-for-github-advanced-security/managing-your-github-advanced-security-licensing.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ Each license for {% data variables.product.prodname_GH_advanced_security %} spec
3434
1. Under "Committers", click **Manage committers**.
3535
1. Under "Total committers", click the plus or minus buttons to add or remove committers.
3636

37-
![Screenshot of the {% data variables.product.prodname_GH_advanced_security %} committers screen. A text box with the number 5, a minus button on its left, and a plus button on its right, are highlighted in an orange outline.](/assets/images/help/enterprises/ghas-add-committers.png)
37+
![Screenshot of the {% data variables.product.prodname_GH_advanced_security %} committers screen. A text box with the number 5, with a minus and a plus button, are outlined in orange.](/assets/images/help/enterprises/ghas-add-committers.png)
3838
1. Click **Update committers**.
3939

4040
## Canceling your {% data variables.product.prodname_GH_advanced_security %} subscription
@@ -44,5 +44,5 @@ Each license for {% data variables.product.prodname_GH_advanced_security %} spec
4444
{% data reusables.enterprise-accounts.license-tab %}
4545
1. To the right of "{% data variables.product.prodname_GH_advanced_security %}", click **Manage**, then click **Cancel Subscription**.
4646

47-
![Screenshot of the "Manage" dropdown in the {% data variables.product.prodname_GH_advanced_security %} licensing screen. The "Cancel Subscription" button is highlighted with an orange outline.](/assets/images/help/enterprises/ghas-cancel-subscription.png)
47+
![Screenshot of the "Manage" dropdown in the {% data variables.product.prodname_GH_advanced_security %} licensing screen. The "Cancel Subscription" button is outlined in orange.](/assets/images/help/enterprises/ghas-cancel-subscription.png)
4848
1. To confirm your cancellation, click **I understand, cancel Advanced Security**.

content/billing/managing-billing-for-your-products/managing-billing-for-github-advanced-security/viewing-your-github-advanced-security-usage.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ You can download the {% data variables.product.prodname_advanced_security %} lic
141141
{%- ifversion ghec %}
142142
1. Under "{% data variables.product.prodname_GH_advanced_security %}," click the **Manage** dropdown and then click **Download report**.
143143

144-
![Screenshot of the "Manage" dropdown in the {% data variables.product.prodname_GH_advanced_security %} licensing screen. The "Download Report" button is highlighted with an orange outline.](/assets/images/help/enterprises/ghas-download-report.png)
144+
![Screenshot of the "Manage" dropdown in the {% data variables.product.prodname_GH_advanced_security %} licensing screen. The "Download Report" button is outlined in orange.](/assets/images/help/enterprises/ghas-download-report.png)
145145

146146
{%- elsif ghes %}
147147
1. Under "{% data variables.product.prodname_GH_advanced_security %}," click **{% octicon "download" aria-hidden="true" %} CSV report** in the header of the "Committers" table.

content/billing/using-the-billing-platform/about-billing-on-github.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,6 @@ If you're an organization or enterprise owner, you can switch between settings f
139139
{% data reusables.user-settings.access_settings %}
140140
1. At the top of the page, to the right of your name, click **Switch settings context**.
141141

142-
![Screenshot of the "Public profile" settings page for The Octocat. Next to the text "Your personal profile," a link, labeled "Switch settings context," is outlined in orange.](/assets/images/help/settings/context-switcher-button.png)
142+
![Screenshot of the "Public profile" settings for The Octocat. Next to "Your personal profile," a "Switch settings context" link is outlined in orange.](/assets/images/help/settings/context-switcher-button.png)
143143
1. Start typing the name of the account you want to switch to, then click the name of the account.
144144
1. In the left sidebar, click **{% octicon "credit-card" aria-hidden="true" %} Billing and plans**.

content/billing/using-the-billing-platform/adding-or-editing-a-payment-method.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ You can update your enterprise account's credit card or PayPal details, or you c
9191
{% data reusables.enterprise-accounts.billing-tab %}
9292
1. Under "Payment information", click **Switch to invoice**.
9393

94-
![Screenshot of the billing page for an enterprise account. In the "Payment information" section, a link, labeled "Switch to invoice", is outlined in dark orange.](/assets/images/help/billing/switch-to-invoice.png)
94+
![Screenshot of the billing page for an enterprise account. In the "Payment information" section, a "Switch to invoice" link is outlined in orange.](/assets/images/help/billing/switch-to-invoice.png)
9595
1. Complete the form, then click **Contact Sales**.
9696

9797
{% endif %}

content/billing/using-the-billing-platform/changing-the-duration-of-your-billing-cycle.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ When you change your billing cycle's duration, your {% data variables.product.pr
6363
{% data reusables.enterprise-accounts.billing-tab %}
6464
1. Under "Payment information", click **Switch to yearly billing and save** or **Switch to monthly billing**.
6565

66-
![Screenshot of the billing page for an enterprise account. In the "Payment information" section, a link, labeled "Switch to yearly billing and save", is outlined in dark orange.](/assets/images/help/billing/switch-to-yearly-billing.png)
66+
![Screenshot of the billing page for an enterprise account. In "Payment information", a "Switch to yearly billing and save" link is outlined in orange.](/assets/images/help/billing/switch-to-yearly-billing.png)
6767
1. Under "How often do you want to be billed?", select a billing cycle.
6868
1. Click **Change your account's billing cycle**.
6969
{% endif %}

0 commit comments

Comments
 (0)