docs: fix a repo param on codespaces url#39540
docs: fix a repo param on codespaces url#39540JamBalaya56562 wants to merge 1 commit intogithub:mainfrom
Conversation
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. This pull request contains code changes, so we will not generate a table of review links. 🤖 This comment is automatically generated. |
|
@JamBalaya56562 I really need to prioritize changing the readme. The reason the link points to github and not docs is because the README.md is meant for internal use, and people at GitHub may need spin up a codespace on any one of our internal repositories. It's why we have a separate contributing doc that we link open source contributors to. Because docs syncs with docs-internal, all the files have to be exactly the same, even those we keep in docs-internal for internal use. I need to make it clearer the readme is for internal use, I just haven't been prioritizing it, but you're the third person in 2 weeks who has wanted to fix it to make it better for open source contributors. 😅 I'm going to close this PR, but thank you for opening it. 💛 That file is legitimately confusing and needs to be fixed, just not in this way. |
Summary:
Documentation:
What's being changed (if available, include any code snippets, screenshots, or gifs):
Check off the following: