Skip to content

security-hardening-with-openid-connect: Add missing comma #37574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Sharra-writes merged 2 commits into from
Apr 16, 2025
Merged

security-hardening-with-openid-connect: Add missing comma #37574

Sharra-writes merged 2 commits into from
Apr 16, 2025
+1 −1

Conversation

@Turbo87
Copy link
Contributor

@Turbo87 Turbo87 commented Apr 16, 2025

Why:

The JSON snippet was missing a comma after the runner_environment value, making the snippet invalid JSON.

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the review environment.

@Turbo87
security-hardening-with-openid-connect: Add missing comma
9c42e3d 
The JSON snippet was missing a comma after the `runner_environment` value, making the snippet invalid JSON.
Copilot AI review requested due to automatic review settings April 16, 2025 10:37
@welcome
Copy link

welcome bot commented Apr 16, 2025

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

Copilot AI reviewed Apr 16, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a JSON formatting error by adding a missing comma to a JSON snippet, ensuring the snippet is valid.

  • Fixed the JSON snippet to include a required comma after the "runner_environment" value.
  • Ensured the document now adheres to correct JSON syntax.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 16, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 16, 2025 •
edited
Loading

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

⚠️ Warning: Our review server is experiencing latency issues.

The table shows the files in the content directory that were changed in this pull request. This helps you review your changes on the review server. Changes to the data directory are not included in this table.

Source Review Production What Changed
actions/security-for-github-actions/security-hardening-your-deployments/about-security-hardening-with-openid-connect.md fpt
ghec
ghes@ 3.16 3.15 3.14 3.13 3.12
fpt
ghec
ghes@ 3.16 3.15 3.14 3.13 3.12

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server

🤖 This comment is automatically generated.

@Sharra-writes Sharra-writes added content This issue or pull request belongs to the Docs Content team and removed triage Do not begin working on this issue until triaged by the team labels Apr 16, 2025
@Sharra-writes
Copy link
Contributor

Sharra-writes commented Apr 16, 2025

Good catch! Thanks for correcting that for us. I'll get this merged as soon as check are passing. ✨

@Sharra-writes Sharra-writes added this pull request to the merge queue Apr 16, 2025
Merged via the queue into github:main with commit 47558ea Apr 16, 2025
43 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Apr 16, 2025

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Sharra-writes Sharra-writes Sharra-writes approved these changes

Assignees

No one assigned

Labels

content This issue or pull request belongs to the Docs Content team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Turbo87 @Sharra-writes