Skip to content

Commit 84051fa

Browse files
authored
Merge pull request #8 from github/ruby3
Upgrade to ruby3(.1.2)
2 parents 0cb5512 + f5b5470 commit 84051fa

20 files changed

+57
-30
lines changed

.github/workflows/lint.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919

2020
- uses: ruby/setup-ruby@8029ebd6e5bd8f4e0d6f7623ea76a01ec5b1010d # [email protected]
2121
with:
22-
ruby-version: 2.7.5
22+
ruby-version: 3.1.2
2323
bundler-cache: true
2424

2525
- name: rubocop

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919

2020
- uses: ruby/setup-ruby@8029ebd6e5bd8f4e0d6f7623ea76a01ec5b1010d # [email protected]
2121
with:
22-
ruby-version: 2.7.5
22+
ruby-version: 3.1.2
2323
bundler-cache: true
2424

2525
- name: rspec tests

.ruby-version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
2.7.5
1+
3.1.2

Gemfile.lock

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
PATH
22
remote: .
33
specs:
4-
entitlements-github-plugin (0.0.2)
5-
entitlements (= 0.1.8)
6-
faraday (>= 1, < 3)
4+
entitlements-github-plugin (0.2.0)
5+
contracts (= 0.17.0)
6+
faraday (~> 2.0)
77
faraday-retry (~> 2.0)
88
octokit (~> 4.25)
99

@@ -19,16 +19,16 @@ GEM
1919
public_suffix (>= 2.0.2, < 6.0)
2020
ast (2.4.2)
2121
concurrent-ruby (1.1.9)
22-
contracts (0.16.0)
23-
contracts-rspec (0.1.0)
22+
contracts (0.17)
2423
crack (0.4.5)
2524
rexml
2625
diff-lcs (1.5.0)
2726
docile (1.4.0)
28-
entitlements (0.1.8)
27+
entitlements (0.2.0)
2928
concurrent-ruby (= 1.1.9)
30-
contracts (= 0.16.0)
31-
net-ldap (~> 0.17.0)
29+
faraday (~> 2.0)
30+
net-ldap (~> 0.17)
31+
octokit (~> 4.18)
3232
optimist (= 3.0.0)
3333
faraday (2.5.2)
3434
faraday-net_http (>= 2.0, < 3.1)
@@ -100,8 +100,8 @@ GEM
100100
docile (~> 1.1)
101101
json (>= 1.8, < 3)
102102
simplecov-html (~> 0.10.0)
103-
simplecov-erb (0.1.1)
104-
simplecov
103+
simplecov-erb (1.0.1)
104+
simplecov (< 1.0)
105105
simplecov-html (0.10.2)
106106
tzinfo (2.0.5)
107107
concurrent-ruby (~> 1.0)
@@ -114,10 +114,9 @@ GEM
114114

115115
PLATFORMS
116116
ruby
117-
x86_64-darwin-20
118117

119118
DEPENDENCIES
120-
contracts-rspec (= 0.1.0)
119+
entitlements (= 0.2.0)
121120
entitlements-github-plugin!
122121
rake (= 13.0.6)
123122
rspec (= 3.8.0)
@@ -127,9 +126,9 @@ DEPENDENCIES
127126
rubocop-performance (= 1.13.3)
128127
rugged (= 0.27.5)
129128
simplecov (= 0.16.1)
130-
simplecov-erb (= 0.1.1)
129+
simplecov-erb (= 1.0.1)
131130
vcr (= 4.0.0)
132131
webmock (= 3.4.2)
133132

134133
BUNDLED WITH
135-
2.3.9
134+
2.3.19

VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
0.0.2
1+
0.2.0

entitlements-github-plugin.gemspec

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ Gem::Specification.new do |s|
1212
s.homepage = "https://github.com/github/entitlements-github-plugin"
1313
s.executables = %w[]
1414

15-
s.add_dependency "entitlements", "0.1.8"
16-
s.add_dependency "faraday", "< 3", ">= 1"
15+
s.add_dependency "contracts", "= 0.17.0"
16+
s.add_dependency "faraday", "~> 2.0"
1717
s.add_dependency "faraday-retry", "~> 2.0"
1818
s.add_dependency "octokit", "~> 4.25"
1919

20-
s.add_development_dependency "contracts-rspec", "= 0.1.0"
20+
s.add_development_dependency "entitlements", "0.2.0"
2121
s.add_development_dependency "rake", "= 13.0.6"
2222
s.add_development_dependency "rspec", "= 3.8.0"
2323
s.add_development_dependency "rspec-core", "= 3.8.0"
@@ -26,7 +26,7 @@ Gem::Specification.new do |s|
2626
s.add_development_dependency "rubocop-performance", "= 1.13.3"
2727
s.add_development_dependency "rugged", "= 0.27.5"
2828
s.add_development_dependency "simplecov", "= 0.16.1"
29-
s.add_development_dependency "simplecov-erb", "= 0.1.1"
29+
s.add_development_dependency "simplecov-erb", "= 1.0.1"
3030
s.add_development_dependency "vcr", "= 4.0.0"
3131
s.add_development_dependency "webmock", "3.4.2"
3232
end

spec/acceptance/Dockerfile.entitlements-github-plugin

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM ruby:2.7.5-buster
1+
FROM ruby:3.1-slim
22
LABEL maintainer="GitHub Security Ops <[email protected]>"
33
ENV HOME /root
44
ENV RELEASE=buster
@@ -9,7 +9,12 @@ WORKDIR /data/entitlements
99
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
1010
build-essential \
1111
cmake \
12-
ldap-utils
12+
gcc \
13+
git \
14+
ldap-utils \
15+
make \
16+
iputils-ping \
17+
pkg-config
1318

1419
# Install bundler
1520
RUN gem install bundler

spec/acceptance/github-server/Dockerfile

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,17 @@
1-
FROM ruby:2.4.4
1+
FROM ruby:3.1-slim
22
LABEL maintainer="GitHub Security Ops <[email protected]>"
33

4+
# Install dependency packages for bootstrapping and running...
5+
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
6+
build-essential \
7+
cmake \
8+
gcc \
9+
git \
10+
ldap-utils \
11+
make \
12+
iputils-ping \
13+
pkg-config
14+
415
# Install gems
516
ENV APP_HOME /app
617
ENV HOME /root

spec/acceptance/github-server/web.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -394,4 +394,4 @@ def graphql_pending_query(query)
394394
end
395395
end
396396

397-
Rack::Handler::WEBrick.run FakeGitHubApi, webrick_options
397+
Rack::Handler::WEBrick.run FakeGitHubApi, **webrick_options

spec/unit/entitlements/backend/github_org/provider_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
let(:provider_config) { config.merge(base: config[:ou]).map { |k, v| [k.to_s, v] }.to_h }
1515

16-
let(:github) { Entitlements::Backend::GitHubOrg::Service.new(config) }
16+
let(:github) { Entitlements::Backend::GitHubOrg::Service.new(**config) }
1717

1818
let(:subject) { described_class.new(config: provider_config) }
1919

0 commit comments

Comments
 (0)