Skip to content

Commit 097ad30

Browse files
committed
Fix docs coverage and add tests coverage
1 parent 1e59d60 commit 097ad30

File tree

5 files changed

+33
-71
lines changed

5 files changed

+33
-71
lines changed

.github/workflows/ci.yml

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,3 +55,21 @@ jobs:
5555
bundle config path vendor/bundle
5656
bundle install --jobs 4 --retry 3
5757
bundle exec rake docs:coverage
58+
tests-coverage:
59+
runs-on: ubuntu-latest
60+
steps:
61+
- uses: actions/checkout@master
62+
- name: Setup Ruby
63+
uses: actions/setup-ruby@v1
64+
with:
65+
ruby-version: 3.0.x
66+
- uses: actions/cache@v2
67+
with:
68+
path: vendor/bundle
69+
key: gems-build-rails-main-ruby-2.7.x-${{ hashFiles('**/Gemfile.lock') }}
70+
- name: Verify docs coverage
71+
run: |
72+
gem install bundler:2.2.32
73+
bundle config path vendor/bundle
74+
bundle install --jobs 4 --retry 3
75+
bundle exec rake tests:coverage

docs/rules/accessibility/avoid-both-disabled-and-aria-disabled.md

Lines changed: 0 additions & 31 deletions
This file was deleted.

lib/tasks/docs.rake

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@ namespace :docs do
44
task :coverage do
55
require "erb_lint/all"
66
require "erblint-github/linters"
7-
8-
Dir[File.join(__dir__, "linters", "github/**/*.rb")].sort.each do |file|
7+
Dir[File.join("lib", "erblint-github", "linters", "github/**/*.rb")].sort.each do |file|
98
rule_documentation_path = file
109
.gsub("#{__dir__}linters/github/", "docs/rules/")
1110
.gsub(".rb", ".md")

lib/tasks/tests.rake

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
# frozen_string_literal: true
2+
3+
namespace :tests do
4+
task :coverage do
5+
require "erb_lint/all"
6+
require "erblint-github/linters"
7+
8+
Dir[File.join("lib", "erblint-github", "linters", "github/**/*.rb")].sort.each do |file|
9+
test_path = file.gsub("lib/erblint-github/linters/github/", "test/linters/").gsub(".rb", "_test.rb")
10+
raise "Missing test. Please add test in #{test_path}" unless File.file?(test_path.to_s)
11+
end
12+
puts "All rules have test coverage."
13+
end
14+
end

test/linters/accessibility/avoid_both_disabled_and_aria_disabled_test.rb

Lines changed: 0 additions & 38 deletions
This file was deleted.

0 commit comments

Comments
 (0)