Skip to content

Commit 2593ad5

Browse files
committed
Also strip punctuation from aria label
1 parent ec7ddd9 commit 2593ad5

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

lib/erblint-github/linters/github/accessibility/avoid_generic_link_text_counter.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ def banned_text?(text)
122122
end
123123

124124
def valid_accessible_name?(aria_label, text)
125-
aria_label.downcase.include?(stripped_text(text))
125+
stripped_text(aria_label).include?(stripped_text(text))
126126
end
127127

128128
def extract_ruby_node(source)

test/linters/accessibility/avoid_generic_link_text_counter_test.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ def test_flags_when_aria_label_does_not_include_visible_link_text
8383
def test_does_not_flag_when_aria_label_includes_visible_link_text
8484
@file = <<~ERB
8585
<a aria-label="Learn more about GitHub Sponsors.">Learn more.</a>
86+
<a aria-label="Learn more about GitHub Sponsors.">Learn more </a>
8687
ERB
8788
@linter.run(processed_source)
8889

0 commit comments

Comments
 (0)