Update test code and comments

Author: khiga8

lib/erblint-github/linters/github/accessibility/avoid_generic_link_text_counter.rb

@@ -42,10 +42,10 @@ def run(processed_source)
 
                 # Checks if nested between two link tags.
                 if link_tag?(prev_node_tag) && link_tag?(next_node_tag) && next_node_tag.closing?
-                  # We skip because we cannot reliably check accessible name given aria-labelledby, or an aria-label that is set to a variable
+                  # Skip because we cannot reliably check accessible name from aria-labelledby, or an aria-label that is set to a variable
                   # with static code analysis.
                   next if aria_labelledby.present? || (aria_label.present? && aria_label.join.include?("<%="))
-                  # We skip because aria-label contains visible text. Relates to Success Criterion 2.5.3: Label in Name
+                  # Skip because aria-label starts with visible text which we allow. Related to Success Criterion 2.5.3: Label in Name
                   next if aria_label.present? && valid_accessible_name?(aria_label.join, text)
 
                   range = prev_node_tag.loc.begin_pos...text_node_tag.loc.end_pos
@@ -81,7 +81,7 @@ def run(processed_source)
                     end
                   end
 
-                  # Skip if `link_to` has `aria-labelledby` or `aria-label` which we cannot be evaluated accurately with ERB lint alone.
+                  # Skips if `link_to` has `aria-labelledby` or `aria-label` which we cannot be evaluated accurately with ERB lint alone.
                   # ERB lint removes Ruby string interpolation so the `aria-label` for "<%= link_to 'Learn more', "aria-label": "Learn #{@some_variable}" %>" will
                   # only be `Learn` which is unreliable so we can't do checks :(
                   banned_text = nil if pair_node.children.first.children.join == "aria-labelledby" || pair_node.children.first.children.join == "aria-label"

test/linters/accessibility/avoid_generic_link_text_counter_test.rb

@@ -84,31 +84,31 @@ def test_ignores_when_aria_labelledby_is_set_on_link_tag
   end
 
   def test_warns_when_link_rails_helper_text_is_banned_text
-    @file = "<%= link_to('click here', redirect_url, id: 'redirect') %>"
+    @file = "<%= link_to('click here', redirect_url) %>"
     @linter.run(processed_source)
 
     refute_empty @linter.offenses
   end
 
   def test_warns_when_link_rails_helper_text_is_banned_text_with_aria_description
     @file = <<~ERB
-      <%= link_to('click here', 'aria-describedby': 'element123', id: 'redirect') %>
+      <%= link_to('click here', redirect_url, 'aria-describedby': 'element123', id: 'redirect') %>
     ERB
     @linter.run(processed_source)
 
     refute_empty @linter.offenses
   end
 
   def test_ignores_when_link_rails_helper_text_is_banned_text_with_aria_labelled_by
-    @file = "<%= link_to('learn more', 'aria-labelledby': 'element1234', id: 'redirect') %>"
+    @file = "<%= link_to('learn more', redirect_url, 'aria-labelledby': 'element1234', id: 'redirect') %>"
     @linter.run(processed_source)
 
     assert_empty @linter.offenses
   end
 
   def test_ignores_when_link_rails_helper_text_is_banned_text_with_aria_label_that_cannot_be_parsed_by_linter
     @file = <<~ERB
-      <%= link_to('learn more', 'aria-label': some_variable, id: 'redirect') %>
+      <%= link_to('learn more', redirect_url, 'aria-label': some_variable, id: 'redirect') %>
     ERB
     @linter.run(processed_source)
 
@@ -117,22 +117,22 @@ def test_ignores_when_link_rails_helper_text_is_banned_text_with_aria_label_that
 
   def test_ignores_when_link_rails_helper_text_is_banned_text_with_aria_label_since_cannot_be_parsed_accurately_by_linter
     @file = <<~ERB
-      <%= link_to('learn more', 'aria-label': "Learn #{@variable}", id: 'redirect') %>
+      <%= link_to('learn more', redirect_url, 'aria-label': "Learn #{@variable}", id: 'redirect') %>
     ERB
     @linter.run(processed_source)
 
     assert_empty @linter.offenses
   end
 
   def test_ignores_when_link_rails_helper_text_is_banned_text_with_aria_label
-    @file = "<%= link_to('learn more', 'aria-label': 'learn more about GitHub', id: 'redirect') %>"
+    @file = "<%= link_to('learn more', redirect_url, 'aria-label': 'learn more about GitHub', id: 'redirect') %>"
     @linter.run(processed_source)
 
     assert_empty @linter.offenses
   end
 
   def test_ignores_when_link_rails_helper_text_is_banned_text_with_aria_label_hash
-    @file = "<%= link_to('learn more', aria: { label: 'learn more about GitHub' }, id: 'redirect') %>"
+    @file = "<%= link_to('learn more', redirect_url, aria: { label: 'learn more about GitHub' }, id: 'redirect') %>"
     @linter.run(processed_source)
 
     assert_empty @linter.offenses