update test and docs

Author: khiga8

docs/rules/accessibility/no-aria-hidden-on-focusable-counter.md

@@ -2,13 +2,15 @@
 
 ## Rule Details
 
-Elements that are focusable should not have `aria-hidden="true"` set.
+Elements that are focusable should never have `aria-hidden="true"` set.
 
-`aria-hidden="true"` hides an element from assistive technologies, but if the element is still reachable by keyboard, it can cause confusion amongst assistie technology users who may be able to reach the element, but not have access to the element or it's information.
+`aria-hidden="true"` hides elements from assistive technologies. `aria-hidden="true"` should only be used to hide non-interactive content such as decorative elements or redundant text. If a focusable element has `aria-hidden="true"`, it can cause confusion amongst assistive technology users who may be able to reach the element but not receive information about it.
 
 ### Resources
 
 - [Accessibility insights: aria-hidden-focus](https://accessibilityinsights.io/info-examples/web/aria-hidden-focus/)
+- [Deque: aria-hidden elements do not contain focusable elements](https://dequeuniversity.com/rules/axe/html/4.4/aria-hidden-focus)
+- [W3: Element with aria-hidden has no content in sequential focus navigation](https://www.w3.org/WAI/standards-guidelines/act/rules/6cfa84/proposed/)
 
 ## Examples
 

test/linters/accessibility/no_aria_hidden_on_focusable_counter_test.rb

@@ -21,18 +21,24 @@ def test_does_not_warn_if_link_has_aria_hidden_false
     assert_empty @linter.offenses
   end
 
-  def test_warns_when_link_has_aria_hidden_true
-    @file = "<a aria-hidden='true' href='github.com'>GitHub</a>"
+  def test_does_not_warn_when_link_has_aria_hidden_true_and_is_not_focusable
+    @file = "<a aria-hidden='true' tabindex='-1' href='github.com'>GitHub</a>"
     @linter.run(processed_source)
 
+    assert_empty @linter.offenses
+  end
+
+  def test_warns_when_element_has_aria_hidden_true_and_not_tab_focusable
+    @file = "<div role='button' tabindex='0' a aria-hidden='true'>GitHub</a>"
+    @linter.run(processed_source)
     refute_empty @linter.offenses
   end
 
-  def test_does_not_warn_when_link_has_aria_hidden_true_and_is_not_focusable
-    @file = "<a aria-hidden='true' tabindex='-1' href='github.com'>GitHub</a>"
+  def test_warns_when_link_has_aria_hidden_true
+    @file = "<a aria-hidden='true' href='github.com'>GitHub</a>"
     @linter.run(processed_source)
 
-    assert_empty @linter.offenses
+    refute_empty @linter.offenses
   end
 
   def test_warns_when_element_has_aria_hidden_true_and_is_tab_focusable