Skip to content

Commit 4a9e2c6

Browse files
authored
Merge pull request #8 from github/kh-create_docs_action
Introduce action to ensure every rule is properly documented
2 parents 245d6a0 + 3e435cf commit 4a9e2c6

File tree

5 files changed

+44
-3
lines changed

5 files changed

+44
-3
lines changed

.github/workflows/ci.yml

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,3 +37,21 @@ jobs:
3737
run: bundle install --jobs 4 --retry 3
3838
- name: Run tests
3939
run: bundle exec rake
40+
docs-coverage:
41+
runs-on: ubuntu-latest
42+
steps:
43+
- uses: actions/checkout@master
44+
- name: Setup Ruby
45+
uses: actions/setup-ruby@v1
46+
with:
47+
ruby-version: 3.0.x
48+
- uses: actions/cache@v2
49+
with:
50+
path: vendor/bundle
51+
key: gems-build-rails-main-ruby-2.7.x-${{ hashFiles('**/Gemfile.lock') }}
52+
- name: Verify docs coverage
53+
run: |
54+
gem install bundler:2.2.32
55+
bundle config path vendor/bundle
56+
bundle install --jobs 4 --retry 3
57+
bundle exec rake docs:coverage

.rubocop.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,13 @@ inherit_gem:
55

66
AllCops:
77
NewCops: enable
8+
SuggestExtensions: false
89

910
Rails/RefuteMethods:
1011
Enabled: false
1112

1213
Style/Documentation:
1314
Enabled: false
15+
16+
Rails/RakeEnvironment:
17+
Enabled: false

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,10 @@ linters:
3131
enabled: true
3232
```
3333
34-
### Rules
34+
## Rules
3535
36-
- [GitHub::Accessibility::ImageHasAlt](./docs/rules/accessibility/no-aria-label-misuse.md)
37-
- [GitHub::Accessibility::NoAriaLabelMisuse](./docs/rules/accessibility/image-has-alt.md)
36+
- [GitHub::Accessibility::ImageHasAlt](./docs/rules/accessibility/image-has-alt.md)
37+
- [GitHub::Accessibility::NoAriaLabelMisuse](./docs/rules/accessibility/no-aria-label-misuse.md)
3838
- [GitHub::Accessibility::NoRedundantImageAlt](./docs/rules/accessibility/no-redundant-image-alt.md)
3939
4040
## Testing

Rakefile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,7 @@ Rake::TestTask.new do |t|
99
t.test_files = FileList[ENV["TESTS"] || "test/**/*_test.rb"]
1010
end
1111

12+
Rake.add_rakelib "lib/tasks"
13+
1214
desc "Run tests"
1315
task default: :test

lib/tasks/docs.rake

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
# frozen_string_literal: true
2+
3+
namespace :docs do
4+
task :coverage do
5+
require "erb_lint/all"
6+
require "erblint-github/linters"
7+
8+
Dir[File.join(__dir__, "linters", "github/**/*.rb")].sort.each do |file|
9+
rule_documentation_path = file
10+
.gsub("#{__dir__}linters/github/", "docs/rules/")
11+
.gsub(".rb", ".md")
12+
.tr("_", "-")
13+
raise "Missing rule documentation. Please document rule in #{rule_documentation_path}" unless File.file?(rule_documentation_path.to_s)
14+
end
15+
puts "All rules have been properly documented."
16+
end
17+
end

0 commit comments

Comments
 (0)