Merge pull request #84 from github/dependabot/bundler/rubocop-1.53.0

Update rubocop requirement from = 1.52.1 to = 1.53.0

Author: lindseywild

Gemfile.lock

@@ -39,6 +39,7 @@ GEM
     i18n (1.13.0)
       concurrent-ruby (~> 1.0)
     json (2.6.3)
+    language_server-protocol (3.17.0.3)
     loofah (2.21.3)
       crass (~> 1.0.2)
       nokogiri (>= 1.12.0)
@@ -53,7 +54,7 @@ GEM
     parser (3.2.2.3)
       ast (~> 2.4.1)
       racc
-    racc (1.6.2)
+    racc (1.7.1)
     rack (3.0.4.1)
     rails-dom-testing (2.0.3)
       activesupport (>= 4.2.0)
@@ -65,8 +66,9 @@ GEM
     rake (13.0.6)
     regexp_parser (2.8.1)
     rexml (3.2.5)
-    rubocop (1.52.1)
+    rubocop (1.53.0)
       json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
       parser (>= 3.2.2.3)
       rainbow (>= 2.2.2, < 4.0)
@@ -104,7 +106,7 @@ DEPENDENCIES
   minitest (~> 5.18.0)
   mocha (~> 2.0.2)
   rake (~> 13.0.6)
-  rubocop (= 1.52.1)
+  rubocop (= 1.53.0)
   rubocop-github (~> 0.20.0)
 
 BUNDLED WITH

erblint-github.gemspec

@@ -21,7 +21,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency "mocha", "~> 2.0.2"
   s.add_development_dependency "rake", "~> 13.0.6"
 
-  s.add_development_dependency "rubocop", "= 1.52.1"
+  s.add_development_dependency "rubocop", "= 1.53.0"
   s.add_development_dependency "rubocop-github", "~> 0.20.0"
   s.metadata["rubygems_mfa_required"] = "true"
 end

lib/erblint-github/linters/custom_helpers.rb

@@ -47,7 +47,7 @@ def counter_correct?(processed_source)
         if offenses_count.zero?
           # have to adjust to get `\n` so we delete the whole line
           add_offense(processed_source.to_source_range(comment_node.loc.adjust(end_pos: 1)), "Unused erblint:counter comment for #{rule_name}", "") if comment_node
-          return
+          return false
         end
 
         first_offense = @offenses[0]