Add helper for showing offense given a source range

Author: khiga8

lib/erblint-github/linters/custom_helpers.rb

@@ -64,6 +64,13 @@ def generate_offense(klass, processed_source, tag, message = nil, replacement =
         add_offense(processed_source.to_source_range(tag.loc), offense, replacement)
       end
 
+      def generate_offense_from_source_range(klass, source_range, message = nil, replacement = nil)
+        message ||= klass::MESSAGE
+        message += "\nLearn more at https://github.com/github/erblint-github#rules.\n"
+        offense = ["#{simple_class_name}:#{message}", source_range.source].join("\n")
+        add_offense(source_range, offense, replacement)
+      end
+
       def possible_attribute_values(tag, attr_name)
         value = tag.attributes[attr_name]&.value || nil
         basic_conditional_code_check(value || "") || [value].compact

lib/erblint-github/linters/github/accessibility/avoid_generic_link_text_counter.rb

@@ -28,14 +28,17 @@ def run(processed_source)
                 prev_node = processed_source.ast.children[index-1]
                 next_node = processed_source.ast.children[index+1]
 
-                next unless tag?(prev_node) && tag?(next_node)
+                next unless tag_type?(prev_node) && tag_type?(next_node)
 
+                text_node_tag = BetterHtml::Tree::Tag.from_node(node)
                 prev_node_tag = BetterHtml::Tree::Tag.from_node(prev_node)
                 next_node_tag = BetterHtml::Tree::Tag.from_node(next_node)
 
                 # We only report if the text is nested between two link tags.
                 if link_tag?(prev_node_tag) && link_tag?(next_node_tag) && next_node_tag.closing?
-                  generate_offense(self.class, processed_source, prev_node_tag)
+                  range = prev_node_tag.loc.begin_pos...text_node_tag.loc.end_pos
+                  source_range = processed_source.to_source_range(range)
+                  generate_offense_from_source_range(self.class, source_range)
                 end
               end
 
@@ -90,7 +93,7 @@ def link_tag?(tag_node)
             tag_node.name == "a"
           end
 
-          def tag?(node)
+          def tag_type?(node)
             node.methods.include?(:type) && node.type == :tag
           end
         end