Rename rule and deprecate old one

Author: khiga8

README.md

@@ -33,7 +33,7 @@ linters:
     enabled: true
   GitHub::Accessibility::ImageHasAlt:
     enabled: true
-  GitHub::Accessibility::LandmarkHasLabel:
+  GitHub::Accessibility::NavigationHasLabel:
     enabled: true
   GitHub::Accessibility::LinkHasHref:
     enabled: true
@@ -58,7 +58,7 @@ linters:
 - [GitHub::Accessibility::AvoidBothDisabledAndAriaDisabled](./docs/rules/accessibility/avoid-both-disabled-and-aria-disabled.md)
 - [GitHub::Accessibility::AvoidGenericLinkText](./docs/rules/accessibility/avoid-generic-link-text.md)
 - [GitHub::Accessibility::DisabledAttribute](./docs/rules/accessibility/disabled-attribute.md)
-- [GitHub::Accessibility::LandmarkHasLabel](./docs/rules/accessibility/landmark-has-label.md)
+- [GitHub::Accessibility::NavigationHasLabel](./docs/rules/accessibility/navigation-has-label.md)
 - [GitHub::Accessibility::LinkHasHref](./docs/rules/accessibility/link-has-href.md)
 - [GitHub::Accessibility::NestedInteractiveElements](./docs/rules/accessibility/nested-interactive-elements.md)
 - [GitHub::Accessibility::IframeHasTitle](./docs/rules/accessibility/iframe-has-title.md)

docs/rules/accessibility/landmark-has-label.md

@@ -0,0 +1,30 @@
+# Navigation Has Label
+
+## Rule Details
+
+This rule enforces that a navigation landmark (a `<nav>` or a `role="navigation"`) has an accessible name. This rule is helpful to enforce for sites (like GitHub) where multiple navigation is common.
+
+The navigation landmark element should have an `aria-label` attribute, or `aria-labelledby` to distinguish it from other elements.
+
+## Resources
+
+- [ARIA Landmarks Example](https://www.w3.org/WAI/ARIA/apg/example-index/landmarks/index.html)
+
+## Examples
+### **Incorrect** code for this rule 👎
+
+```erb
+<!-- incorrect -->
+<nav>
+  <h1>This is a text</h1>
+</nav>
+```
+
+### **Correct** code for this rule  👍
+
+```erb
+<!-- correct -->
+<nav aria-labelledby="title_id"t>
+  <h1 id="title_id">This is a text</h1>
+</nav>
+```

docs/rules/accessibility/navigation-has-label.md

@@ -6,17 +6,12 @@ module ERBLint
   module Linters
     module GitHub
       module Accessibility
-        class LandmarkHasLabel < Linter
+        class NavigationHasLabel < Linter
           include ERBLint::Linters::CustomHelpers
           include LinterRegistry
 
           MESSAGE = "The navigation landmark should have a unique accessible name via `aria-label` or `aria-labelledby`."
 
-          class ConfigSchema < LinterConfig
-            property :counter_enabled, accepts: [true, false], default: false, reader: :counter_enabled?
-          end
-          self.config_schema = ConfigSchema
-
           def run(processed_source)
             tags(processed_source).each do |tag|
               next if tag.closing?
@@ -30,10 +25,6 @@ def run(processed_source)
               end
 
             end
-
-            if @config.counter_enabled?
-              counter_correct?(processed_source)
-            end
           end
         end
       end

…thub/accessibility/landmark_has_label.rb …ub/accessibility/navigation_has_label.rblib/erblint-github/linters/github/accessibility/landmark_has_label.rb renamed to lib/erblint-github/linters/github/accessibility/navigation_has_label.rb lib/erblint-github/linters/github/accessibility/landmark_has_label.rb renamed to lib/erblint-github/linters/github/accessibility/navigation_has_label.rb

@@ -2,9 +2,9 @@
 
 require "test_helper"
 
-class LandmarkHasLabelTest < LinterTestCase
+class NavigationHasLabelTest < LinterTestCase
   def linter_class
-    ERBLint::Linters::GitHub::Accessibility::LandmarkHasLabel
+    ERBLint::Linters::GitHub::Accessibility::NavigationHasLabel
   end
 
   def test_warns_if_navigation_landmark_has_no_label