Remove counter-related tests

khiga8 · khiga8 · commit b3eef57247ba · 2023-06-08T18:25:08.000-04:00
diff --git a/test/custom_helpers_test.rb b/test/custom_helpers_test.rb
@@ -20,35 +20,6 @@ def extended_linter
     @linter.extend(ERBLint::Linters::CustomHelpers)
   end
 
-  def test_counter_correct_does_not_add_offense_if_counter_matches_offense_count
-    @file = <<~HTML
-      <%# erblint:counter CustomHelpersTest::FakeLinter 1 %>
-    HTML
-    @linter.offenses = ["fake offense"]
-
-    extended_linter.counter_correct?(processed_source)
-    assert_empty @linter.offenses
-  end
-
-  def test_counter_correct_add_offense_if_counter_comment_is_unused
-    @file = <<~HTML
-      <%# erblint:counter CustomHelpersTest::FakeLinter 1 %>
-    HTML
-
-    extended_linter.counter_correct?(processed_source)
-    assert_equal "Unused erblint:counter comment for CustomHelpersTest::FakeLinter", @linter.offenses.first.message
-  end
-
-  def test_counter_correct_add_offense_if_counter_comment_count_is_incorrect
-    @file = <<~HTML
-      <%# erblint:counter CustomHelpersTest::FakeLinter 2 %>
-    HTML
-    @linter.offenses = ["fake offense"]
-
-    extended_linter.counter_correct?(processed_source)
-    assert_equal "Incorrect erblint:counter number for CustomHelpersTest::FakeLinter. Expected: 2, actual: 1.", @linter.offenses.first.message
-  end
-
   def test_generate_offense_with_message_defined_in_linter_class
     @file = <<~HTML
       <%# erblint:disable CustomHelpersTest::FakeLinter %>
diff --git a/test/linters/accessibility/avoid_both_disabled_and_aria_disabled_test.rb b/test/linters/accessibility/avoid_both_disabled_and_aria_disabled_test.rb
@@ -35,25 +35,4 @@ def test_does_not_warn_if_only_aria_disabled_attribute_is_set
 
     assert_empty @linter.offenses
   end
-
-  def test_adds_extra_offense_to_add_counter_comment_if_counter_config_enabled
-    @file = ELEMENTS_WITH_NATIVE_DISABLED_ATTRIBUTE_SUPPORT.map do |element|
-      "<#{element} aria-disabled='true' disabled> </#{element}>"
-    end.join
-    @linter.config.counter_enabled = true
-    @linter.run(processed_source)
-
-    assert_equal @linter.offenses.count, 8
-    assert_match(/If you must, add <%# erblint:disable GitHub::Accessibility::AvoidBothDisabledAndAriaDisabled %> at the end of the offending line to bypass this check./, @linter.offenses.last.message)
-  end
-
-  def test_does_not_raise_when_ignore_comment_with_correct_count_if_counter_enabled
-    @file = <<~ERB
-      <%# erblint:counter GitHub::Accessibility::AvoidBothDisabledAndAriaDisabledCounter 1 %>
-      <button disabled aria-disabled="true">Some text</button>
-    ERB
-    @linter.config.counter_enabled = true
-    @linter.run(processed_source)
-    assert_empty @linter.offenses
-  end
 end
diff --git a/test/linters/accessibility/avoid_generic_link_text_test.rb b/test/linters/accessibility/avoid_generic_link_text_test.rb
@@ -144,15 +144,4 @@ def test_handles_files_with_various_links
     refute_empty @linter.offenses
     assert_equal 3, @linter.offenses.count
   end
-
-  def test_does_not_warns_if_element_has_correct_counter_comment_if_config_enabled
-    @file = <<~ERB
-      <%# erblint:counter GitHub::Accessibility::AvoidGenericLinkTextCounter 1 %>
-      <a>Link</a>
-    ERB
-    @linter.config.counter_enabled = true
-    @linter.run(processed_source)
-
-    assert_equal 0, @linter.offenses.count
-  end
 end
diff --git a/test/linters/accessibility/disabled_attribute_test.rb b/test/linters/accessibility/disabled_attribute_test.rb
@@ -22,15 +22,4 @@ def test_does_not_warn_if_valid_element_has_disabled_attribute
 
     assert_empty @linter.offenses
   end
-
-  def test_does_not_warns_if_element_has_correct_counter_comment_if_config_enabled
-    @file = <<~ERB
-      <%# erblint:counter GitHub::Accessibility::DisabledAttributeCounter 1 %>
-      <a href='https://github.com/' disabled>Go to GitHub</a>
-    ERB
-    @linter.config.counter_enabled = true
-    @linter.run(processed_source)
-
-    assert_equal 0, @linter.offenses.count
-  end
 end
diff --git a/test/linters/accessibility/iframe_has_title_test.rb b/test/linters/accessibility/iframe_has_title_test.rb
@@ -27,14 +27,4 @@ def test_does_not_warn_if_iframe_has_title_set_to_string
 
     assert_empty @linter.offenses
   end
-
-  def test_does_not_raise_when_ignore_comment_with_correct_count_if_config_enabled
-    @file = <<~ERB
-      <%# erblint:counter GitHub::Accessibility::IframeHasTitleCounter 1 %>
-      <iframe></iframe>
-    ERB
-    @linter.config.counter_enabled = true
-    @linter.run(processed_source)
-    assert_empty @linter.offenses
-  end
 end
diff --git a/test/linters/accessibility/image_has_alt_test.rb b/test/linters/accessibility/image_has_alt_test.rb
@@ -27,14 +27,4 @@ def test_does_not_warn_if_image_has_alt_attribute_set_to_string
 
     assert_empty @linter.offenses
   end
-
-  def test_does_not_raise_when_ignore_comment_with_correct_count_if_config_enabled
-    @file = <<~ERB
-      <%# erblint:counter GitHub::Accessibility::ImageHasAltCounter 1 %>
-      <img></img>
-    ERB
-    @linter.config.counter_enabled = true
-    @linter.run(processed_source)
-    assert_empty @linter.offenses
-  end
 end
diff --git a/test/linters/accessibility/link_has_href_test.rb b/test/linters/accessibility/link_has_href_test.rb
@@ -22,15 +22,4 @@ def test_does_not_warn_if_link_has_href_attribute
 
     assert_empty @linter.offenses
   end
-
-  def test_does_not_warn_if_link_has_href_attribute_and_has_correct_counter_comment
-    @file = <<~ERB
-      <%# erblint:counter GitHub::Accessibility::LinkHasHrefCounter 1 %>
-      <a>Go to GitHub</a>
-    ERB
-    @linter.config.counter_enabled = true
-    @linter.run(processed_source)
-
-    assert_equal 0, @linter.offenses.count
-  end
 end
diff --git a/test/linters/accessibility/nested_interactive_elements_test.rb b/test/linters/accessibility/nested_interactive_elements_test.rb
@@ -22,15 +22,4 @@ def test_does_not_warn_if_there_are_not_nested_interactive_elements
 
     assert_empty @linter.offenses
   end
-
-  def test_does_not_warn_if_there_are_not_nested_interactive_elements_and_has_correct_counter_comment_with_config_enabled
-    @file = <<~ERB
-      <%# erblint:counter GitHub::Accessibility::NestedInteractiveElementsCounter 1 %>
-      <button><a href='https://github.com/'>Go to GitHub</a></button>
-    ERB
-    @linter.config.counter_enabled = true
-    @linter.run(processed_source)
-
-    assert_equal 0, @linter.offenses.count
-  end
 end
diff --git a/test/linters/accessibility/no_aria_label_misuse_test.rb b/test/linters/accessibility/no_aria_label_misuse_test.rb
@@ -74,15 +74,4 @@ def test_does_not_warn_if_generic_elements_have_aria_label_and_allowed_role
     @linter.run(processed_source)
     assert_empty @linter.offenses
   end
-
-  def test_does_not_raise_when_ignore_comment_with_correct_count_and_config_enabled
-    @file = <<~ERB
-      <%# erblint:counter GitHub::Accessibility::NoAriaLabelMisuseCounter 2 %>
-      <span aria-label="This is a bad idea">Some text</span>
-      <span aria-label="This is still a bad idea">More text</span>
-    ERB
-    @linter.config.counter_enabled = true
-    @linter.run(processed_source)
-    assert_empty @linter.offenses
-  end
 end
diff --git a/test/linters/accessibility/no_positive_tab_index_test.rb b/test/linters/accessibility/no_positive_tab_index_test.rb
@@ -27,14 +27,4 @@ def test_does_not_warn_if_zero_tabindex_is_used
 
     assert_empty @linter.offenses
   end
-
-  def test_does_not_raise_when_ignore_comment_with_correct_count_and_config_enabled
-    @file = <<~ERB
-      <%# erblint:counter GitHub::Accessibility::NoPositiveTabIndexCounter 1 %>
-      <button tabindex='1'></button>
-    ERB
-    @linter.config.counter_enabled = true
-    @linter.run(processed_source)
-    assert_empty @linter.offenses
-  end
 end
diff --git a/test/linters/accessibility/no_redundant_image_alt_test.rb b/test/linters/accessibility/no_redundant_image_alt_test.rb
@@ -27,15 +27,4 @@ def test_does_not_warn_if_alt_contains_no_redundant_text
 
     assert_empty @linter.offenses
   end
-
-  def test_does_not_raise_when_ignore_comment_with_correct_count_and_config_enabled
-    @file = <<~ERB
-      <%# erblint:counter GitHub::Accessibility::NoRedundantImageAltCounter 1 %>
-      <img alt='image of an octopus'></img>
-    ERB
-
-    @linter.config.counter_enabled = true
-    @linter.run(processed_source)
-    assert_empty @linter.offenses
-  end
 end
diff --git a/test/linters/accessibility/no_title_attribute_test.rb b/test/linters/accessibility/no_title_attribute_test.rb
@@ -7,7 +7,7 @@ def linter_class
     ERBLint::Linters::GitHub::Accessibility::NoTitleAttribute
   end
 
-  def test_warns_if_element_sets_title_and_has_no_counter_comment
+  def test_warns_if_element_sets_title
     @file = "<img title='octopus'></img>"
     @linter.run(processed_source)
 
@@ -16,17 +16,6 @@ def test_warns_if_element_sets_title_and_has_no_counter_comment
     assert_match(/The title attribute should never be used unless for an `<iframe>` as it is inaccessible for several groups of users./, error_messages.last)
   end
 
-  def test_does_not_warns_if_element_sets_title_and_has_correct_counter_comment_if_config_enabled
-    @file = <<~ERB
-      <%# erblint:counter GitHub::Accessibility::NoTitleAttributeCounter 1 %>
-      <a href="/" title="bad">some website</a>
-    ERB
-    @linter.config.counter_enabled = true
-    @linter.run(processed_source)
-
-    assert_equal 0, @linter.offenses.count
-  end
-
   def test_does_not_warn_if_iframe_sets_title
     @file = "<iframe title='Introduction video'></iframe>"
     @linter.run(processed_source)
diff --git a/test/linters/accessibility/svg_has_accessible_text_test.rb b/test/linters/accessibility/svg_has_accessible_text_test.rb
@@ -31,15 +31,4 @@ def test_does_not_warn_if_svg_has_accesible_text
 
     assert_empty @linter.offenses
   end
-
-  def test_does_not_warn_if_svg_has_accesible_text_and_has_correct_counter_comment_if_config_enabled
-    @file = <<~ERB
-      <%# erblint:counter GitHub::Accessibility::SvgHasAccessibleTextCounter 1 %>
-      <svg height='100' width='100'><circle cx='50' cy='50' r='40' stroke='black' stroke-width='3' fill='red'/></svg>
-    ERB
-    @linter.config.counter_enabled = true
-    @linter.run(processed_source)
-
-    assert_equal 0, @linter.offenses.count
-  end
 end
