Skip to content

Commit dec5d16

Browse files
committed
simplify logic for now
1 parent 7fe1fd1 commit dec5d16

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

lib/erblint-github/linters/github/accessibility/no_visually_hidden_interactive_elements.rb

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,10 @@ class NoVisuallyHiddenInteractiveElements < Linter
1414
MESSAGE = "Avoid visually hidding interactive elements. Visually hiding interactive elements can be confusing to sighted keyboard users as it appears their focus has been lost when they navigate to the hidden element"
1515

1616
def run(processed_source)
17-
visually_hidden = false
18-
1917
tags(processed_source).each do |tag|
2018
next if tag.closing?
2119
classes = possible_attribute_values(tag, "class")
22-
visually_hidden = true if classes.include?("sr-only")
23-
next unless classes.include?("sr-only") || visually_hidden
24-
if INTERACTIVE_ELEMENTS.include?(tag.name)
20+
if classes.include?("sr-only") && INTERACTIVE_ELEMENTS.include?(tag.name)
2521
generate_offense(self.class, processed_source, tag)
2622
end
2723
end

0 commit comments

Comments
 (0)