Deprecate counter from readme and names

khiga8 · khiga8 · commit eb9c210f24c4 · 2023-04-03T09:36:08.000-04:00
diff --git a/README.md b/README.md
@@ -56,19 +56,19 @@ linters:
 ## Rules
 
 - [GitHub::Accessibility::AvoidBothDisabledAndAriaDisabledCounter](./docs/rules/accessibility/avoid-both-disabled-and-aria-disabled.md)
-- [GitHub::Accessibility::AvoidGenericLinkTextCounter](./docs/rules/accessibility/avoid-generic-link-text-counter.md)
+- [GitHub::Accessibility::AvoidGenericLinkTextCounter](./docs/rules/accessibility/avoid-generic-link-text.md)
 - [GitHub::Accessibility::DisabledAttributeCounter](./docs/rules/accessibility/disabled-attribute.md)
 - [GitHub::Accessibility::LandmarkHasLabelCounter](./docs/rules/accessibility/landmark-has-label.md)
 - [GitHub::Accessibility::LinkHasHrefCounter](./docs/rules/accessibility/link-has-href.md)
-- [GitHub::Accessibility::NestedInteractiveElementsCounter](./docs/rules/accessibility/nested-interactive-elements-counter.md)
-- [GitHub::Accessibility::IframeHasTitleCounter](./docs/rules/accessibility/iframe-has-title-counter.md)
-- [GitHub::Accessibility::ImageHasAltCounter](./docs/rules/accessibility/image-has-alt-counter.md)
-- [GitHub::Accessibility::NoAriaHiddenOnFocusableCounter](./docs/rules/accessibility/no-aria-hidden-on-focusable-counter.md)
-- [GitHub::Accessibility::NoAriaLabelMisuseCounter](./docs/rules/accessibility/no-aria-label-misuse-counter.md)
-- [GitHub::Accessibility::NoPositiveTabIndexCounter](./docs/rules/accessibility/no-positive-tab-index-counter.md)
-- [GitHub::Accessibility::NoRedundantImageAltCounter](./docs/rules/accessibility/no-redundant-image-alt-counter.md)
-- [GitHub::Accessibility::NoTitleAttributeCounter](./docs/rules/accessibility/no-title-attribute-counter.md)
-- [GitHub::Accessibility::SvgHasAccessibleTextCounter](./docs/rules/accessibility/svg-has-accessible-text-counter.md)
+- [GitHub::Accessibility::NestedInteractiveElementsCounter](./docs/rules/accessibility/nested-interactive-elements.md)
+- [GitHub::Accessibility::IframeHasTitleCounter](./docs/rules/accessibility/iframe-has-title.md)
+- [GitHub::Accessibility::ImageHasAltCounter](./docs/rules/accessibility/image-has-alt.md)
+- [GitHub::Accessibility::NoAriaHiddenOnFocusableCounter](./docs/rules/accessibility/no-aria-hidden-on-focusable.md)
+- [GitHub::Accessibility::NoAriaLabelMisuseCounter](./docs/rules/accessibility/no-aria-label-misuse.md)
+- [GitHub::Accessibility::NoPositiveTabIndexCounter](./docs/rules/accessibility/no-positive-tab-index.md)
+- [GitHub::Accessibility::NoRedundantImageAltCounter](./docs/rules/accessibility/no-redundant-image-alt.md)
+- [GitHub::Accessibility::NoTitleAttributeCounter](./docs/rules/accessibility/no-title-attribute.md)
+- [GitHub::Accessibility::SvgHasAccessibleTextCounter](./docs/rules/accessibility/svg-has-accessible-text.md)
 
 ## Disabling a rule (Deprecated)
 
diff --git a/lib/erblint-github/linters/github/accessibility/disabled_attribute.rb b/lib/erblint-github/linters/github/accessibility/disabled_attribute.rb
@@ -22,7 +22,7 @@ class ConfigSchema < LinterConfig
             property :counter_enabled, accepts: [true, false], default: false, reader: :counter_enabled?
           end
           self.config_schema = ConfigSchema
-          
+
           def run(processed_source)
             tags(processed_source).each do |tag|
               next if tag.closing?
diff --git a/lib/erblint-github/linters/github/accessibility/image_has_alt.rb b/lib/erblint-github/linters/github/accessibility/image_has_alt.rb
@@ -6,7 +6,7 @@ module ERBLint
   module Linters
     module GitHub
       module Accessibility
-        class ImageHasAltCounter < Linter
+        class ImageHasAlt < Linter
           include ERBLint::Linters::CustomHelpers
           include LinterRegistry
 
@@ -16,7 +16,7 @@ class ConfigSchema < LinterConfig
             property :counter_enabled, accepts: [true, false], default: false, reader: :counter_enabled?
           end
           self.config_schema = ConfigSchema
-          
+
           def run(processed_source)
             tags(processed_source).each do |tag|
               next if tag.name != "img"
diff --git a/lib/erblint-github/linters/github/accessibility/nested_interactive_elements.rb b/lib/erblint-github/linters/github/accessibility/nested_interactive_elements.rb
@@ -6,7 +6,7 @@ module ERBLint
   module Linters
     module GitHub
       module Accessibility
-        class NestedInteractiveElementsCounter < Linter
+        class NestedInteractiveElements < Linter
           include ERBLint::Linters::CustomHelpers
           include LinterRegistry
 
diff --git a/lib/erblint-github/linters/github/accessibility/no_aria_hidden_on_focusable.rb b/lib/erblint-github/linters/github/accessibility/no_aria_hidden_on_focusable.rb
@@ -6,12 +6,12 @@ module ERBLint
   module Linters
     module GitHub
       module Accessibility
-        class NoAriaHiddenOnFocusableCounter < Linter
+        class NoAriaHiddenOnFocusable < Linter
           include ERBLint::Linters::CustomHelpers
           include LinterRegistry
 
           MESSAGE = "Elements that are focusable should not have `aria-hidden='true' because it will cause confusion for assistive technology users."
-          
+
           class ConfigSchema < LinterConfig
             property :counter_enabled, accepts: [true, false], default: false, reader: :counter_enabled?
           end
diff --git a/lib/erblint-github/linters/github/accessibility/no_aria_label_misuse.rb b/lib/erblint-github/linters/github/accessibility/no_aria_label_misuse.rb
@@ -6,7 +6,7 @@ module ERBLint
   module Linters
     module GitHub
       module Accessibility
-        class NoAriaLabelMisuseCounter < Linter
+        class NoAriaLabelMisuse < Linter
           include ERBLint::Linters::CustomHelpers
           include LinterRegistry
 
@@ -22,7 +22,7 @@ class ConfigSchema < LinterConfig
             property :counter_enabled, accepts: [true, false], default: false, reader: :counter_enabled?
           end
           self.config_schema = ConfigSchema
-          
+
           def run(processed_source)
             tags(processed_source).each do |tag|
               next if tag.closing?
diff --git a/lib/erblint-github/linters/github/accessibility/no_positive_tab_index.rb b/lib/erblint-github/linters/github/accessibility/no_positive_tab_index.rb
@@ -6,7 +6,7 @@ module ERBLint
   module Linters
     module GitHub
       module Accessibility
-        class NoPositiveTabIndexCounter < Linter
+        class NoPositiveTabIndex < Linter
           include ERBLint::Linters::CustomHelpers
           include LinterRegistry
 
@@ -16,7 +16,7 @@ class ConfigSchema < LinterConfig
             property :counter_enabled, accepts: [true, false], default: false, reader: :counter_enabled?
           end
           self.config_schema = ConfigSchema
-          
+
           def run(processed_source)
             tags(processed_source).each do |tag|
               next if tag.closing?
diff --git a/lib/erblint-github/linters/github/accessibility/no_redundant_image_alt.rb b/lib/erblint-github/linters/github/accessibility/no_redundant_image_alt.rb
@@ -6,7 +6,7 @@ module ERBLint
   module Linters
     module GitHub
       module Accessibility
-        class NoRedundantImageAltCounter < Linter
+        class NoRedundantImageAlt < Linter
           include ERBLint::Linters::CustomHelpers
           include LinterRegistry
 
@@ -17,7 +17,7 @@ class ConfigSchema < LinterConfig
             property :counter_enabled, accepts: [true, false], default: false, reader: :counter_enabled?
           end
           self.config_schema = ConfigSchema
-          
+
           def run(processed_source)
             tags(processed_source).each do |tag|
               next if tag.name != "img"
diff --git a/lib/erblint-github/linters/github/accessibility/no_title_attribute.rb b/lib/erblint-github/linters/github/accessibility/no_title_attribute.rb
@@ -6,7 +6,7 @@ module ERBLint
   module Linters
     module GitHub
       module Accessibility
-        class NoTitleAttributeCounter < Linter
+        class NoTitleAttribute < Linter
           include ERBLint::Linters::CustomHelpers
           include LinterRegistry
 
@@ -16,7 +16,7 @@ class ConfigSchema < LinterConfig
             property :counter_enabled, accepts: [true, false], default: false, reader: :counter_enabled?
           end
           self.config_schema = ConfigSchema
-          
+
           def run(processed_source)
             tags(processed_source).each do |tag|
               next if tag.name == "iframe"
diff --git a/lib/erblint-github/linters/github/accessibility/svg_has_accessible_text.rb b/lib/erblint-github/linters/github/accessibility/svg_has_accessible_text.rb
@@ -6,7 +6,7 @@ module ERBLint
   module Linters
     module GitHub
       module Accessibility
-        class SvgHasAccessibleTextCounter < Linter
+        class SvgHasAccessibleText < Linter
           include ERBLint::Linters::CustomHelpers
           include LinterRegistry
 
@@ -16,7 +16,7 @@ class ConfigSchema < LinterConfig
             property :counter_enabled, accepts: [true, false], default: false, reader: :counter_enabled?
           end
           self.config_schema = ConfigSchema
-          
+
           def run(processed_source)
             current_svg = nil
             has_accessible_label = false
