test: add missing Gemini API target test coverage to fix CI branch coverage regression (#1662)

* test: add missing Gemini API target test coverage in cli.test.ts

Agent-Logs-Url: https://github.com/github/gh-aw-firewall/sessions/0ed05562-3ddb-490f-9b6a-dd5cfa3bb0fc

* fix: rename describe block to reflect all API target constants

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Landon Cox <landon.cox@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: 3 people

src/cli.test.ts

@@ -1,5 +1,5 @@
 import { Command } from 'commander';
-import { parseEnvironmentVariables, parseDomains, parseDomainsFile, escapeShellArg, joinShellArgs, parseVolumeMounts, isValidIPv4, isValidIPv6, parseDnsServers, parseDnsOverHttps, validateAgentImage, isAgentImagePreset, AGENT_IMAGE_PRESETS, processAgentImageOption, processLocalhostKeyword, validateSkipPullWithBuildLocal, validateAllowHostPorts, validateAllowHostServicePorts, applyHostServicePortsConfig, parseMemoryLimit, validateFormat, validateApiProxyConfig, buildRateLimitConfig, validateRateLimitFlags, hasRateLimitOptions, collectRulesetFile, validateApiTargetInAllowedDomains, DEFAULT_OPENAI_API_TARGET, DEFAULT_ANTHROPIC_API_TARGET, DEFAULT_COPILOT_API_TARGET, emitApiProxyTargetWarnings, formatItem, program, parseAgentTimeout, applyAgentTimeout, handlePredownloadAction, resolveApiTargetsToAllowedDomains, extractGhesDomainsFromEngineApiTarget, extractGhecDomainsFromServerUrl } from './cli';
+import { parseEnvironmentVariables, parseDomains, parseDomainsFile, escapeShellArg, joinShellArgs, parseVolumeMounts, isValidIPv4, isValidIPv6, parseDnsServers, parseDnsOverHttps, validateAgentImage, isAgentImagePreset, AGENT_IMAGE_PRESETS, processAgentImageOption, processLocalhostKeyword, validateSkipPullWithBuildLocal, validateAllowHostPorts, validateAllowHostServicePorts, applyHostServicePortsConfig, parseMemoryLimit, validateFormat, validateApiProxyConfig, buildRateLimitConfig, validateRateLimitFlags, hasRateLimitOptions, collectRulesetFile, validateApiTargetInAllowedDomains, DEFAULT_OPENAI_API_TARGET, DEFAULT_ANTHROPIC_API_TARGET, DEFAULT_COPILOT_API_TARGET, DEFAULT_GEMINI_API_TARGET, emitApiProxyTargetWarnings, formatItem, program, parseAgentTimeout, applyAgentTimeout, handlePredownloadAction, resolveApiTargetsToAllowedDomains, extractGhesDomainsFromEngineApiTarget, extractGhecDomainsFromServerUrl } from './cli';
 import { redactSecrets } from './redact-secrets';
 import * as fs from 'fs';
 import * as path from 'path';
@@ -1780,11 +1780,12 @@ describe('cli', () => {
     });
   });
 
-  describe('DEFAULT_OPENAI_API_TARGET and DEFAULT_ANTHROPIC_API_TARGET', () => {
+  describe('DEFAULT_*_API_TARGET constants', () => {
     it('should have correct default values', () => {
       expect(DEFAULT_OPENAI_API_TARGET).toBe('api.openai.com');
       expect(DEFAULT_ANTHROPIC_API_TARGET).toBe('api.anthropic.com');
       expect(DEFAULT_COPILOT_API_TARGET).toBe('api.githubcopilot.com');
+      expect(DEFAULT_GEMINI_API_TARGET).toBe('generativelanguage.googleapis.com');
     });
   });
 
@@ -1988,6 +1989,55 @@ describe('cli', () => {
       expect(warnings[1]).toContain('--anthropic-api-target=anthropic.internal');
       expect(warnings[2]).toContain('--copilot-api-target=copilot.internal');
     });
+
+    it('should emit warning for custom Gemini target not in allowed domains', () => {
+      const warnings: string[] = [];
+      emitApiProxyTargetWarnings(
+        { enableApiProxy: true, geminiApiTarget: 'custom.gemini-router.internal' },
+        ['github.com'],
+        (msg) => warnings.push(msg)
+      );
+      expect(warnings).toHaveLength(1);
+      expect(warnings[0]).toContain('--gemini-api-target=custom.gemini-router.internal');
+    });
+
+    it('should emit no warnings when custom Gemini target is in allowed domains', () => {
+      const warnings: string[] = [];
+      emitApiProxyTargetWarnings(
+        { enableApiProxy: true, geminiApiTarget: 'gemini.example.com' },
+        ['example.com'],
+        (msg) => warnings.push(msg)
+      );
+      expect(warnings).toHaveLength(0);
+    });
+
+    it('should use default Gemini target when geminiApiTarget is undefined', () => {
+      const warnings: string[] = [];
+      emitApiProxyTargetWarnings(
+        { enableApiProxy: true, geminiApiTarget: undefined },
+        ['github.com'],
+        (msg) => warnings.push(msg)
+      );
+      // Default target is not in 'github.com' but since it IS the default, no warning is emitted
+      expect(warnings).toHaveLength(0);
+    });
+
+    it('should emit warnings for all four custom targets when none are in allowed domains', () => {
+      const warnings: string[] = [];
+      emitApiProxyTargetWarnings(
+        {
+          enableApiProxy: true,
+          openaiApiTarget: 'openai.internal',
+          anthropicApiTarget: 'anthropic.internal',
+          copilotApiTarget: 'copilot.internal',
+          geminiApiTarget: 'gemini.internal',
+        },
+        ['github.com'],
+        (msg) => warnings.push(msg)
+      );
+      expect(warnings).toHaveLength(4);
+      expect(warnings[3]).toContain('--gemini-api-target=gemini.internal');
+    });
   });
 
   describe('resolveApiTargetsToAllowedDomains', () => {
@@ -2117,6 +2167,28 @@ describe('cli', () => {
       // Whitespace-only and empty values are filtered out
       expect(domains).toHaveLength(0);
     });
+
+    it('should add gemini-api-target option to allowed domains', () => {
+      const domains: string[] = ['github.com'];
+      resolveApiTargetsToAllowedDomains({ geminiApiTarget: 'custom.gemini.internal' }, domains);
+      expect(domains).toContain('custom.gemini.internal');
+      expect(domains).toContain('https://custom.gemini.internal');
+    });
+
+    it('should read GEMINI_API_TARGET from env when flag not set', () => {
+      const domains: string[] = [];
+      const env = { GEMINI_API_TARGET: 'env.gemini.internal' };
+      resolveApiTargetsToAllowedDomains({}, domains, env);
+      expect(domains).toContain('env.gemini.internal');
+    });
+
+    it('should prefer geminiApiTarget option over GEMINI_API_TARGET env var', () => {
+      const domains: string[] = [];
+      const env = { GEMINI_API_TARGET: 'env.gemini.internal' };
+      resolveApiTargetsToAllowedDomains({ geminiApiTarget: 'flag.gemini.internal' }, domains, env);
+      expect(domains).toContain('flag.gemini.internal');
+      expect(domains).not.toContain('env.gemini.internal');
+    });
   });
 
   describe('formatItem', () => {