Skip to content

Commit c5b303b

Browse files
Potential fix for pull request finding 'CodeQL / Log injection'
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
1 parent b387976 commit c5b303b

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

containers/cli-proxy/tcp-tunnel.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,10 @@
1313

1414
const net = require('net');
1515

16+
function sanitizeForLog(value) {
17+
return String(value).replace(/[\r\n]/g, '');
18+
}
19+
1620
const localPortStr = process.argv[2];
1721
const remoteHost = process.argv[3];
1822
const remotePortStr = process.argv[4];
@@ -38,12 +42,12 @@ const server = net.createServer(client => {
3842
const upstream = net.connect(remotePort, remoteHost);
3943
client.pipe(upstream);
4044
upstream.pipe(client);
41-
client.on('error', (err) => { console.error('[tcp-tunnel] Client error:', err.message); upstream.destroy(); });
42-
upstream.on('error', (err) => { console.error('[tcp-tunnel] Upstream error:', err.message); client.destroy(); });
45+
client.on('error', (err) => { console.error('[tcp-tunnel] Client error:', sanitizeForLog(err.message)); upstream.destroy(); });
46+
upstream.on('error', (err) => { console.error('[tcp-tunnel] Upstream error:', sanitizeForLog(err.message)); client.destroy(); });
4347
});
4448

4549
server.on('error', (err) => {
46-
console.error('[tcp-tunnel] Server error:', err.message);
50+
console.error('[tcp-tunnel] Server error:', sanitizeForLog(err.message));
4751
process.exit(1);
4852
});
4953

0 commit comments

Comments
 (0)