fix runtime errors

Author: jalafel

cmd/gh-classroom/clone/student-repos/student-repos.go

@@ -22,6 +22,7 @@ func NewCmdStudentRepo(f *cmdutil.Factory) *cobra.Command {
 	var page int
 	var perPage int
 	var getAll bool
+	var verbose bool
 
 	cmd := &cobra.Command{
 		Use:   "student-repos",
@@ -90,9 +91,10 @@ func NewCmdStudentRepo(f *cmdutil.Factory) *cobra.Command {
 			}
 
 			totalCloned := 0
+			cloneErrors := []string{}
 			for _, acceptAssignment := range acceptedAssignmentList.AcceptedAssignments {
 				clonePath := filepath.Join(fullPath, acceptAssignment.Repository.Name)
-				_, err := CloneRepository(clonePath, acceptAssignment.Repository.FullName, gh)
+				err := utils.CloneRepository(clonePath, acceptAssignment.Repository.FullName, gh.Exec)
 				if err != nil {
 						errMsg := fmt.Sprintf("Error cloning %s: %v", acceptAssignment.Repository.FullName, err)
 						fmt.Println(errMsg)

cmd/gh-classroom/clone/utils/clone-repository.go

@@ -8,19 +8,16 @@ import (
     "bytes"
 )
 
-// GitHubExec defines an interface for executing GitHub CLI commands.
 // This abstraction allows for easier testing and decoupling from the actual CLI.
 // Exec invokes a gh command in a subprocess and captures the output and error streams.
-type GitHubExec interface {
-    Exec(args ...string) (stdout, stderr bytes.Buffer, err error)
-}
+type GitHubExec func(args ...string) (stdout, stderr bytes.Buffer, err error)
 
 // CloneRepository attempts to clone a repository into the specified path.
 // It returns an error if the cloning process fails.
-func CloneRepository(clonePath string, repoFullName string, gh GitHubExec) error {
+func CloneRepository(clonePath string, repoFullName string, ghExec GitHubExec) error {
     if _, err := os.Stat(clonePath); os.IsNotExist(err) {
         fmt.Printf("Cloning into: %v\n", clonePath)
-        _, _, err := gh.Exec("repo", "clone", repoFullName, "--", clonePath)
+        _, _, err := ghExec("repo", "clone", repoFullName, "--", clonePath)
         if err != nil {
             fmt.Printf("error cloning %s: %v\n", repoFullName, err)
             return fmt.Errorf("error cloning %s: %v", repoFullName, err)

cmd/gh-classroom/clone/utils/clone-repository_test.go

@@ -10,16 +10,6 @@ import (
     "path/filepath"
 )
 
-// MockGitHubExec is a mock of the GitHubExec interface for testing.
-type MockGitHubExec struct {
-    ExecFunc func(args ...string) (stdout, stderr bytes.Buffer, err error)
-}
-
-func (m *MockGitHubExec) Exec(args ...string) (stdout, stderr bytes.Buffer, err error) {
-    return m.ExecFunc(args...)
-}
-
-
 func TestCloneRepository(t *testing.T) {
     tmpDir, err := ioutil.TempDir("", "cloneTest")
     if err != nil {
@@ -29,32 +19,28 @@ func TestCloneRepository(t *testing.T) {
     // Test cases
     tests := []struct {
         name       string
-        execMock   *MockGitHubExec
+        execMock   GitHubExec
         clonePath  string
         repoFullName string
         wantErr    bool
         errMsg     string
     }{
         {
             name: "successful clone",
-            execMock: &MockGitHubExec{
-                ExecFunc: func(args ...string) (stdout bytes.Buffer, stderr bytes.Buffer, err error) {
+            execMock: func(args ...string) (stdout bytes.Buffer, stderr bytes.Buffer, err error) {
                     var stdoutBuf, stderrBuf bytes.Buffer
                     stdoutBuf.Write([]byte("your string here"))
                     return stdoutBuf, stderrBuf, nil
-                },
             },
             clonePath: "", // Will be set to a temp directory in the test
             repoFullName: "example/repo",
             wantErr:    false,
         },
         {
             name: "clone failure",
-            execMock: &MockGitHubExec{
-                ExecFunc: func(args ...string) (stdout bytes.Buffer, stderr bytes.Buffer, err error) {
+            execMock: func(args ...string) (stdout bytes.Buffer, stderr bytes.Buffer, err error) {
                     var stdoutBuf, stderrBuf bytes.Buffer
                     return stdoutBuf, stderrBuf, errors.New("clone error")
-                },
             },
             clonePath:  filepath.Join(tmpDir, "repo"),
             repoFullName: "example/repo",
@@ -63,11 +49,9 @@ func TestCloneRepository(t *testing.T) {
         },
         {
             name: "repository already exists",
-            execMock: &MockGitHubExec{
-                ExecFunc: func(args ...string) (stdout bytes.Buffer, stderr bytes.Buffer, err error) {
+            execMock: func(args ...string) (stdout bytes.Buffer, stderr bytes.Buffer, err error) {
                     var stdoutBuf, stderrBuf bytes.Buffer
                     return stdoutBuf, stderrBuf, nil
-                },
             },
             clonePath:  "./repo", // Current directory always exists
             repoFullName: "example/repo",

cmd/gh-classroom/pull/student-repos/student-repos.go

@@ -80,7 +80,7 @@ func NewCmdStudentReposPull(f *cmdutil.Factory) *cobra.Command {
 				if !r.IsDir() {
 					continue
 				}
-				clonePath := filepath.Join(fullPath, r.Name)
+				clonePath := filepath.Join(fullPath, r.Name())
 				fmt.Printf("Pulling repo: %v\n", clonePath)
 				err = os.Chdir(clonePath)
 				if err != nil {

pkg/classroom/classroom.go

@@ -56,7 +56,7 @@ type Classroom struct {
 
 type GithubRepository struct {
 	Id            int    `json:"id"`
-	Name					string `json:name`
+	Name					string `json:"name"`
 	FullName      string `json:"full_name"`
 	HtmlUrl       string `json:"html_url"`
 	NodeId        string `json:"node_id"`