add graceful failures and remove Name() function

Author: jalafel

cmd/gh-classroom/clone/student-repos/student-repos.go

@@ -13,6 +13,7 @@ import (
 	"github.com/github/gh-classroom/cmd/gh-classroom/shared"
 	"github.com/github/gh-classroom/pkg/classroom"
 	"github.com/spf13/cobra"
+	"github.com/github/gh-classroom/cmd/gh-classroom/clone/utils"
 )
 
 func NewCmdStudentRepo(f *cmdutil.Factory) *cobra.Command {
@@ -90,17 +91,24 @@ func NewCmdStudentRepo(f *cmdutil.Factory) *cobra.Command {
 
 			totalCloned := 0
 			for _, acceptAssignment := range acceptedAssignmentList.AcceptedAssignments {
-				clonePath := filepath.Join(fullPath, acceptAssignment.Repository.Name())
-				if _, err := os.Stat(clonePath); os.IsNotExist(err) {
-					fmt.Printf("Cloning into: %v\n", clonePath)
-					_, _, err := gh.Exec("repo", "clone", acceptAssignment.Repository.FullName, "--", clonePath)
-					totalCloned++
-					if err != nil {
-						log.Fatal(err)
-						return
-					}
+				clonePath := filepath.Join(fullPath, acceptAssignment.Repository.Name)
+				_, err := CloneRepository(clonePath, acceptAssignment.Repository.FullName, gh)
+				if err != nil {
+						errMsg := fmt.Sprintf("Error cloning %s: %v", acceptAssignment.Repository.FullName, err)
+						fmt.Println(errMsg)
+						cloneErrors = append(cloneErrors, errMsg)
+						continue // Continue with the next iteration
+				}
+				totalCloned++
+			}
+			if len(cloneErrors) > 0 {
+				fmt.Println("Some repositories failed to clone.")
+				if !verbose {
+						fmt.Println("Run with --verbose flag to see more details")
 				} else {
-					fmt.Printf("Skip existing repo: %v use gh classroom pull to get new commits\n", clonePath)
+						for _, errMsg := range cloneErrors {
+								fmt.Println(errMsg)
+						}
 				}
 			}
 			if getAll {
@@ -117,6 +125,7 @@ func NewCmdStudentRepo(f *cmdutil.Factory) *cobra.Command {
 	cmd.Flags().IntVar(&page, "page", 1, "Page number")
 	cmd.Flags().IntVar(&perPage, "per-page", 15, "Number of accepted assignments per page")
 	cmd.Flags().BoolVar(&getAll, "all", true, "Clone All assignments by default")
+	cmd.Flags().BoolVarP(&verbose, "verbose", "v", false, "Enable verbose error output")
 
 	return cmd
 }

cmd/gh-classroom/pull/student-repos/student-repos.go

@@ -80,7 +80,7 @@ func NewCmdStudentReposPull(f *cmdutil.Factory) *cobra.Command {
 				if !r.IsDir() {
 					continue
 				}
-				clonePath := filepath.Join(fullPath, r.Name())
+				clonePath := filepath.Join(fullPath, r.Name)
 				fmt.Printf("Pulling repo: %v\n", clonePath)
 				err = os.Chdir(clonePath)
 				if err != nil {

pkg/classroom/classroom.go

@@ -138,7 +138,3 @@ func (a Assignment) IsGroupAssignment() bool {
 func (a AcceptedAssignment) RepositoryUrl() string {
 	return a.Repository.HtmlUrl
 }
-
-func (gr GithubRepository) Name() string {
-	return strings.Split(gr.FullName, "/")[1]
-}

pkg/classroom/classroom_test.go

@@ -121,11 +121,4 @@ func TestAcceptedAssignments(t *testing.T) {
 		acceptedAssignment := AcceptedAssignment{Repository: GithubRepository{HtmlUrl: "https://github.com/owner/repo"}}
 		assert.Equal(t, acceptedAssignment.RepositoryUrl(), "https://github.com/owner/repo")
 	})
-}
-
-func TestGithubRepositories(t *testing.T) {
-	t.Run("Returns repo name", func(t *testing.T) {
-		repository := GithubRepository{FullName: "owner/repo"}
-		assert.Equal(t, repository.Name(), "repo")
-	})
-}
+}