fix(labels): write tests and fix loop logic

Author: nobe4

internal/cmd/inputs.go

@@ -6,11 +6,12 @@ import (
 	"slices"
 )
 
-var errIgnoreLabelsConflict = errors.New("--ignore-labels contains a value which conflicts with --labels")
+var errLabelsConflict = errors.New("--ignore-labels contains a value which conflicts with --labels")
 
 // validateInputs checks if the provided inputs are valid
 func ValidateInputs(args []string) error {
 	if err := ValidateLabels(selectLabels, ignoreLabels); err != nil {
+		return err
 	}
 
 	// If no args and no file, we can't proceed
@@ -32,7 +33,7 @@ func ValidateLabels(selectLabels []string, ignoreLabels []string) error {
 	// Check for conflicts between ignoreLabels and selectLabels
 	for _, ignoreL := range ignoreLabels {
 		if i := slices.Index(selectLabels, ignoreL); i != -1 {
-			return fmt.Errorf("%w: %q %q", errIgnoreLabelsConflict, ignoreLabels[i], selectLabels)
+			return fmt.Errorf("%w: %q %q", errLabelsConflict, selectLabels[i], ignoreLabels)
 		}
 	}
 

internal/cmd/inputs_test.go

@@ -1,12 +1,53 @@
 package cmd
 
 import (
-	"bytes"
-	"log/slog"
+	"errors"
 	"os"
 	"testing"
 )
 
+func TestValidateLabels(t *testing.T) {
+	t.Parallel()
+
+	tests := []struct {
+		selectLabels []string
+		ignoreLabels []string
+		want         error
+	}{
+		{
+			want: nil,
+		},
+		{
+			selectLabels: []string{"a"},
+			ignoreLabels: []string{"b"},
+			want:         nil,
+		},
+		{
+			selectLabels: []string{"a"},
+			ignoreLabels: []string{"a", "b"},
+			want:         errLabelsConflict,
+		},
+		{
+			selectLabels: []string{"a", "b"},
+			ignoreLabels: []string{"b"},
+			want:         errLabelsConflict,
+		},
+	}
+
+	for _, test := range tests {
+		t.Run("", func(t *testing.T) {
+			t.Parallel()
+
+			got := ValidateLabels(test.selectLabels, test.ignoreLabels)
+
+			if !errors.Is(got, test.want) {
+				t.Fatalf("want %s, but go %s", test.want, got)
+			}
+		})
+	}
+}
+
+/*
 // mockLogger creates a test logger that writes to a bytes.Buffer
 func setupMockLogger() (*bytes.Buffer, func()) {
 	var buf bytes.Buffer
@@ -18,7 +59,6 @@ func setupMockLogger() (*bytes.Buffer, func()) {
 	}
 }
 
-/*
 func TestValidateInputs_NoReposSpecified(t *testing.T) {
 	// Save original values
 	origReposFile := reposFile