Skip to content

Commit 4b27406

Browse files
authored
Merge pull request #1389 from github/dylan-smith/fix-codeql-warning
Fix for code scanning alert no. 932: Missed opportunity to use Where
2 parents 7beadd7 + aace929 commit 4b27406

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

src/ado2gh/Commands/GenerateScript/GenerateScriptCommandHandler.cs

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -109,12 +109,10 @@ private async Task CheckForDuplicateRepoNames()
109109
{
110110
foreach (var teamProject in await _adoInspectorService.GetTeamProjects(org))
111111
{
112-
foreach (var repo in await _adoInspectorService.GetRepos(org, teamProject))
112+
foreach (var repo in (await _adoInspectorService.GetRepos(org, teamProject))
113+
.Where(repo => !seen.Add(GetGithubRepoName(teamProject, repo.Name))))
113114
{
114-
if (!seen.Add(GetGithubRepoName(teamProject, repo.Name)))
115-
{
116-
_log.LogWarning($"DUPLICATE REPO NAME: {GetGithubRepoName(teamProject, repo.Name)}");
117-
}
115+
_log.LogWarning($"DUPLICATE REPO NAME: {GetGithubRepoName(teamProject, repo.Name)}");
118116
}
119117
}
120118
}

0 commit comments

Comments
 (0)