Skip to content

Commit 75e8af6

Browse files
committed
Rename test to be more descriptive
Renamed Source_Pat_Should_Default_To_Target_Pat to Should_Pass_Target_Pat_From_Cli_Args_To_Factory for clarity - the new name better describes what the test is verifying.
1 parent 43ef4b0 commit 75e8af6

File tree

2 files changed

+2
-40
lines changed

2 files changed

+2
-40
lines changed

src/OctoshiftCLI.Tests/gei/Commands/MigrateCodeScanningAlerts/MigrateCodeScanningAlertsCommandTests.cs

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public void Should_Have_Options()
4949
}
5050

5151
[Fact]
52-
public void Source_Pat_Should_Default_To_Target_Pat()
52+
public void Should_Pass_Target_Pat_From_Cli_Args_To_Factory()
5353
{
5454
var targetToken = "target-token";
5555

@@ -87,23 +87,4 @@ public void Should_Pass_Source_Pat_From_Cli_Args_To_Factory()
8787

8888
_mockCodeScanningAlertServiceFactory.Verify(m => m.Create(It.IsAny<string>(), sourceToken, It.IsAny<string>(), targetToken, It.IsAny<bool>()));
8989
}
90-
91-
[Fact]
92-
public void Should_Pass_Target_Pat_From_Cli_Args_To_Factory()
93-
{
94-
var targetToken = "target-token";
95-
96-
var args = new MigrateCodeScanningAlertsCommandArgs()
97-
{
98-
SourceOrg = "source-org",
99-
SourceRepo = "source-repo",
100-
TargetOrg = "target-org",
101-
TargetRepo = "target-repo",
102-
GithubTargetPat = targetToken,
103-
};
104-
105-
_command.BuildHandler(args, _serviceProvider);
106-
107-
_mockCodeScanningAlertServiceFactory.Verify(m => m.Create(It.IsAny<string>(), targetToken, It.IsAny<string>(), targetToken, It.IsAny<bool>()));
108-
}
10990
}

src/OctoshiftCLI.Tests/gei/Commands/MigrateSecretAlerts/MigrateSecretAlertsCommandTests.cs

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public void Should_Have_Options()
4949
}
5050

5151
[Fact]
52-
public void Source_Pat_Should_Default_To_Target_Pat()
52+
public void Should_Pass_Target_Pat_From_Cli_Args_To_Factory()
5353
{
5454
var targetToken = "target-token";
5555

@@ -87,23 +87,4 @@ public void Should_Pass_Source_Pat_From_Cli_Args_To_Factory()
8787

8888
_mockSecretScanningAlertServiceFactory.Verify(m => m.Create(It.IsAny<string>(), sourceToken, It.IsAny<string>(), targetToken, It.IsAny<bool>()));
8989
}
90-
91-
[Fact]
92-
public void Should_Pass_Target_Pat_From_Cli_Args_To_Factory()
93-
{
94-
var targetToken = "target-token";
95-
96-
var args = new MigrateSecretAlertsCommandArgs()
97-
{
98-
SourceOrg = "source-org",
99-
SourceRepo = "source-repo",
100-
TargetOrg = "target-org",
101-
TargetRepo = "target-repo",
102-
GithubTargetPat = targetToken,
103-
};
104-
105-
_command.BuildHandler(args, _serviceProvider);
106-
107-
_mockSecretScanningAlertServiceFactory.Verify(m => m.Create(It.IsAny<string>(), targetToken, It.IsAny<string>(), targetToken, It.IsAny<bool>()));
108-
}
10990
}

0 commit comments

Comments
 (0)