Skip to content

Commit be2c1cc

Browse files
committed
address first round of pr review comments
1 parent ef6779a commit be2c1cc

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

src/Octoshift/Services/ArchiveUploader.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,6 @@ private void SetStreamSizeLimitFromEnvironment()
185185

186186
var limitBytes = (int)((long)limitInMebibytes * BYTES_PER_MEBIBYTE);
187187
_streamSizeLimit = limitBytes;
188-
_log.LogInformation($"Multipart upload part size set to {limitInMebibytes} MB.");
188+
_log.LogInformation($"Multipart upload part size set to {limitInMebibytes} MiB.");
189189
}
190190
}

src/OctoshiftCLI.IntegrationTests/GhesToGithub.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public GhesToGithub(ITestOutputHelper output)
5353

5454
_sourceGithubHttpClient = new HttpClient();
5555
_sourceGithubClient = new GithubClient(logger, _sourceGithubHttpClient, new VersionChecker(_versionClient, logger), new RetryPolicy(logger), new DateTimeProvider(), sourceGithubToken);
56-
_archiveUploader = new ArchiveUploader(_sourceGithubClient, UPLOADS_URL, logger, retryPolicy, environmentVariableProvider);
56+
_archiveUploader = new ArchiveUploader(_targetGithubClient, UPLOADS_URL, logger, retryPolicy, environmentVariableProvider);
5757
_sourceGithubApi = new GithubApi(_sourceGithubClient, GHES_API_URL, new RetryPolicy(logger), _archiveUploader);
5858

5959
_targetGithubHttpClient = new HttpClient();

src/OctoshiftCLI.Tests/Octoshift/Services/ArchiveUploadersTests.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ public void Constructor_Should_Use_Valid_Environment_Variable_Value()
6161

6262
// Assert
6363
archiveUploader._streamSizeLimit.Should().Be(customSizeBytes);
64-
logMock.Verify(x => x.LogInformation($"Multipart upload part size set to 10 MB."), Times.Once);
64+
logMock.Verify(x => x.LogInformation($"Multipart upload part size set to 10 MiB."), Times.Once);
6565
}
6666

6767
[Fact]
@@ -187,7 +187,7 @@ public void Constructor_Should_Accept_Value_Equal_To_Minimum()
187187

188188
// Assert
189189
archiveUploader._streamSizeLimit.Should().Be(minimumSizeBytes);
190-
logMock.Verify(x => x.LogInformation($"Multipart upload part size set to 5 MB."), Times.Once);
190+
logMock.Verify(x => x.LogInformation($"Multipart upload part size set to 5 MiB."), Times.Once);
191191
}
192192

193193
[Fact]
@@ -209,7 +209,7 @@ public void Constructor_Should_Accept_Large_Valid_Value()
209209

210210
// Assert
211211
archiveUploader._streamSizeLimit.Should().Be(largeSizeBytes);
212-
logMock.Verify(x => x.LogInformation($"Multipart upload part size set to 500 MB."), Times.Once);
212+
logMock.Verify(x => x.LogInformation($"Multipart upload part size set to 500 MiB."), Times.Once);
213213
}
214214

215215
[Fact]

0 commit comments

Comments
 (0)