Merge pull request #1390 from github/dylan-smith/fix-path-combine

Fix for code scanning alert no. 984: Call to System.IO.Path.Combine

Author: dylan-smith

src/OctoshiftCLI.IntegrationTests/TestHelper.cs

@@ -158,7 +158,7 @@ public async Task ResetGithubTestEnvironment(string githubOrg)
 
         public async Task InitializeBbsRepo(string bbsProjectKey, string repoName)
         {
-            var repoPath = Path.Combine(Path.GetTempPath(), $"{repoName}-{Guid.NewGuid()}");
+            var repoPath = Path.Join(Path.GetTempPath(), $"{repoName}-{Guid.NewGuid()}");
 
             Directory.CreateDirectory(repoPath);
 

src/ado2gh/Program.cs

@@ -82,7 +82,7 @@ public static async Task Main(string[] args)
 
         private static void WarnIfNotUsingExtension()
         {
-            if (!Path.TrimEndingDirectorySeparator(AppContext.BaseDirectory).EndsWith(Path.Combine("extensions", "gh-ado2gh").ToString()))
+            if (!Path.TrimEndingDirectorySeparator(AppContext.BaseDirectory).EndsWith(Path.Join("extensions", "gh-ado2gh")))
             {
                 Logger.LogWarning("You are not running the ado2gh CLI as a gh extension. This is not recommended, please run: gh extension install github/gh-ado2gh");
             }