Merge pull request #701 from github/gh-ost/patch-1

Shlomi Noach · web-flow · commit 0d773f7b3d5b · 2019-01-28T08:26:34.000+02:00
inspect: remove redundant join conditions
diff --git a/go/logic/inspect.go b/go/logic/inspect.go
@@ -622,8 +622,6 @@ func (this *Inspector) getCandidateUniqueKeys(tableName string) (uniqueKeys [](*
       GROUP BY TABLE_SCHEMA, TABLE_NAME, INDEX_NAME
     ) AS UNIQUES
     ON (
-      COLUMNS.TABLE_SCHEMA = UNIQUES.TABLE_SCHEMA AND
-      COLUMNS.TABLE_NAME = UNIQUES.TABLE_NAME AND
       COLUMNS.COLUMN_NAME = UNIQUES.FIRST_COLUMN_NAME
     )
     WHERE

Original file line number	Diff line number	Diff line change
`@@ -622,8 +622,6 @@ func (this Inspector) getCandidateUniqueKeys(tableName string) (uniqueKeys [](`
`622`	`622`	`GROUP BY TABLE_SCHEMA, TABLE_NAME, INDEX_NAME`
`623`	`623`	`) AS UNIQUES`
`624`	`624`	`ON (`
`625`		`- COLUMNS.TABLE_SCHEMA = UNIQUES.TABLE_SCHEMA AND`
`626`		`- COLUMNS.TABLE_NAME = UNIQUES.TABLE_NAME AND`
`627`	`625`	`COLUMNS.COLUMN_NAME = UNIQUES.FIRST_COLUMN_NAME`
`628`	`626`	`)`
`629`	`627`	`WHERE`