Merge pull request #191 from github/sql-mode-strict

Shlomi Noach · web-flow · commit 2a00abfc99fe · 2016-08-25T08:23:44.000+02:00
DML write sets sql_mode to STRICT ALL TABLES
diff --git a/go/logic/applier.go b/go/logic/applier.go
@@ -871,7 +871,10 @@ func (this *Applier) ApplyDMLEventQuery(dmlEvent *binlog.BinlogDMLEvent) error {
 		if err != nil {
 			return err
 		}
-		if _, err := tx.Exec("SET SESSION time_zone = '+00:00'"); err != nil {
+		if _, err := tx.Exec(`SET
+			SESSION time_zone = '+00:00',
+			sql_mode = CONCAT(@@session.sql_mode, ',STRICT_ALL_TABLES')
+			`); err != nil {
 			return err
 		}
 		if _, err := tx.Exec(query, args...); err != nil {

Original file line number	Diff line number	Diff line change
`@@ -871,7 +871,10 @@ func (this Applier) ApplyDMLEventQuery(dmlEvent binlog.BinlogDMLEvent) error {`
`871`	`871`	`if err != nil {`
`872`	`872`	`return err`
`873`	`873`	`}`
`874`		`- if _, err := tx.Exec("SET SESSION time_zone = '+00:00'"); err != nil {`
	`874`	+ if _, err := tx.Exec(`SET
	`875`	`+ SESSION time_zone = '+00:00',`
	`876`	`+ sql_mode = CONCAT(@@session.sql_mode, ',STRICT_ALL_TABLES')`
	`877`	+ `); err != nil {
`875`	`878`	`return err`
`876`	`879`	`}`
`877`	`880`	`if _, err := tx.Exec(query, args...); err != nil {`