Comments 2

timvaillancourt · timvaillancourt · commit 35a9cbbd3333 · 2022-12-12T22:58:03.000+01:00
diff --git a/go/base/utils.go b/go/base/utils.go
@@ -59,8 +59,7 @@ func StringContainsAll(s string, substrings ...string) bool {
 	return nonEmptyStringsFound
 }
 
-// ValidateConnection confirms the database server info matches the provided connection config. On success
-// the function returns a server version as a string, otherwise an empty string and an error is returned.
+// ValidateConnection confirms the database server info matches the provided connection config.
 func ValidateConnection(serverInfo *mysql.ServerInfo, connectionConfig *mysql.ConnectionConfig, migrationContext *MigrationContext, name string) error {
 	// AliyunRDS set users port to "NULL", replace it by gh-ost param
 	// GCP set users port to "NULL", replace it by gh-ost param

Original file line number	Diff line number	Diff line change
`@@ -59,8 +59,7 @@ func StringContainsAll(s string, substrings ...string) bool {`
`59`	`59`	`return nonEmptyStringsFound`
`60`	`60`	`}`
`61`	`61`
`62`		`-// ValidateConnection confirms the database server info matches the provided connection config. On success`
`63`		`-// the function returns a server version as a string, otherwise an empty string and an error is returned.`
	`62`	`+// ValidateConnection confirms the database server info matches the provided connection config.`
`64`	`63`	`func ValidateConnection(serverInfo mysql.ServerInfo, connectionConfig mysql.ConnectionConfig, migrationContext *MigrationContext, name string) error {`
`65`	`64`	`// AliyunRDS set users port to "NULL", replace it by gh-ost param`
`66`	`65`	`// GCP set users port to "NULL", replace it by gh-ost param`