Add test

Author: timvaillancourt

go/base/utils_test.go

@@ -1,13 +1,15 @@
 /*
-   Copyright 2016 GitHub Inc.
+   Copyright 2022 GitHub Inc.
 	 See https://github.com/github/gh-ost/blob/master/LICENSE
 */
 
 package base
 
 import (
+	gosql "database/sql"
 	"testing"
 
+	"github.com/github/gh-ost/go/mysql"
 	"github.com/openark/golib/log"
 	test "github.com/openark/golib/tests"
 )
@@ -27,3 +29,67 @@ func TestStringContainsAll(t *testing.T) {
 	test.S(t).ExpectTrue(StringContainsAll(s, "insert", ""))
 	test.S(t).ExpectTrue(StringContainsAll(s, "insert", "update", "delete"))
 }
+
+func TestValidateConnection(t *testing.T) {
+	connectionConfig := &mysql.ConnectionConfig{
+		Key: mysql.InstanceKey{
+			Hostname: t.Name(),
+			Port:     mysql.DefaultInstancePort,
+		},
+	}
+	// check valid port matches on plain mysql
+	{
+		migrationContext := &MigrationContext{Log: NewDefaultLogger()}
+		serverInfo := &mysql.ServerInfo{
+			Port: gosql.NullInt64{Int64: mysql.DefaultInstancePort, Valid: true},
+		}
+		test.S(t).ExpectNil(ValidateConnection(serverInfo, connectionConfig, migrationContext, "test"))
+	}
+	// check NULL port validates when AliyunRDS=true
+	{
+		migrationContext := &MigrationContext{
+			Log:       NewDefaultLogger(),
+			AliyunRDS: true,
+		}
+		serverInfo := &mysql.ServerInfo{
+			Port: gosql.NullInt64{Int64: 0, Valid: false},
+		}
+		test.S(t).ExpectNil(ValidateConnection(serverInfo, connectionConfig, migrationContext, "test"))
+	}
+	// check NULL port validates when AzureMySQL=true
+	{
+		migrationContext := &MigrationContext{
+			Log:        NewDefaultLogger(),
+			AzureMySQL: true,
+		}
+		serverInfo := &mysql.ServerInfo{
+			Port: gosql.NullInt64{Int64: 0, Valid: false},
+		}
+		test.S(t).ExpectNil(ValidateConnection(serverInfo, connectionConfig, migrationContext, "test"))
+	}
+	// check NULL port validates when GoogleCloudPlatform=true
+	{
+		migrationContext := &MigrationContext{
+			Log:                 NewDefaultLogger(),
+			GoogleCloudPlatform: true,
+		}
+		serverInfo := &mysql.ServerInfo{
+			Port: gosql.NullInt64{Int64: 0, Valid: false},
+		}
+		test.S(t).ExpectNil(ValidateConnection(serverInfo, connectionConfig, migrationContext, "test"))
+	}
+	// check extra_port validates when port=NULL
+	{
+		migrationContext := &MigrationContext{Log: NewDefaultLogger()}
+		serverInfo := &mysql.ServerInfo{
+			ExtraPort: gosql.NullInt64{Int64: mysql.DefaultInstancePort, Valid: true},
+		}
+		test.S(t).ExpectNil(ValidateConnection(serverInfo, connectionConfig, migrationContext, "test"))
+	}
+	// check validation fails when port and extra_port are invalid
+	{
+		migrationContext := &MigrationContext{Log: NewDefaultLogger()}
+		serverInfo := &mysql.ServerInfo{}
+		test.S(t).ExpectNotNil(ValidateConnection(serverInfo, connectionConfig, migrationContext, "test"))
+	}
+}

go/logic/inspect.go

@@ -369,7 +369,7 @@ func (this *Inspector) validateBinlogs() error {
 		this.migrationContext.Log.Infof("%s has %s binlog_format. I will change it to ROW, and will NOT change it back, even in the event of failure.", this.connectionConfig.Key.String(), this.ServerInfo().BinlogFormat)
 	}
 
-	if this.ServerInfo().BinlogRowImage != "FULL" {
+	if strings.ToUpper(this.ServerInfo().BinlogRowImage) != "FULL" {
 		return fmt.Errorf("%s has '%s' binlog_row_image, and only 'FULL' is supported. This operation cannot proceed. You may `set global binlog_row_image='full'` and try again", this.connectionConfig.Key.String(), this.ServerInfo().BinlogRowImage)
 	}