Skip to content

Commit 59c1a24

Browse files
committed
remove useless func per review
1 parent 0310f9f commit 59c1a24

File tree

1 file changed

+1
-8
lines changed

1 file changed

+1
-8
lines changed

go/logic/migrator.go

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -364,7 +364,7 @@ func (this *Migrator) Migrate() (err error) {
364364
// Attempt to do this if AttemptInstantDDL is set.
365365
if this.migrationContext.AttemptInstantDDL {
366366
this.migrationContext.Log.Infof("Attempting to execute alter with ALGORITHM=INSTANT")
367-
if err := this.attemptInstantDDL(); err == nil {
367+
if err := this.applier.AttemptInstantDDL(); err == nil {
368368
this.migrationContext.Log.Infof("Success! table %s.%s migrated instantly", sql.EscapeName(this.migrationContext.DatabaseName), sql.EscapeName(this.migrationContext.OriginalTableName))
369369
return nil
370370
} else {
@@ -745,13 +745,6 @@ func (this *Migrator) initiateServer() (err error) {
745745
return nil
746746
}
747747

748-
// attemptInstantDDL tries to apply the DDL statement directly to the table
749-
// using a ALGORITHM=INSTANT assertion. If this fails, it will return an error,
750-
// in which case the original algorithm should be used.
751-
func (this *Migrator) attemptInstantDDL() (err error) {
752-
return this.applier.AttemptInstantDDL()
753-
}
754-
755748
// initiateInspector connects, validates and inspects the "inspector" server.
756749
// The "inspector" server is typically a replica; it is where we issue some
757750
// queries such as:

0 commit comments

Comments
 (0)