Skip to content

Commit a79109b

Browse files
author
Shlomi Noach
authored
Merge pull request #589 from github/go-1-10
build.sh: supporting go1.9 and above
2 parents 3a3ee49 + eaf1b51 commit a79109b

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ Please see [Coding gh-ost](doc/coding-ghost.md) for a guide to getting started d
9494

9595
[Download latest release here](https://github.com/github/gh-ost/releases/latest)
9696

97-
`gh-ost` is a Go project; it is built with Go `1.8` (though `1.7` should work as well). To build on your own, use either:
97+
`gh-ost` is a Go project; it is built with Go `1.9` and above. To build on your own, use either:
9898
- [script/build](https://github.com/github/gh-ost/blob/master/script/build) - this is the same build script used by CI hence the authoritative; artifact is `./bin/gh-ost` binary.
9999
- [build.sh](https://github.com/github/gh-ost/blob/master/build.sh) for building `tar.gz` artifacts in `/tmp/gh-ost`
100100

build.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ function build {
1010
GOOS=$3
1111
GOARCH=$4
1212

13-
if [[ $(go version | egrep "go1[.][012345678]") ]]; then
13+
if ! go version | egrep -q 'go(1[.]9|1[.]1[0-9])' ; then
1414
echo "go version is too low. Must use 1.9 or above"
1515
exit 1
1616
fi

0 commit comments

Comments
 (0)