Merge pull request #810 from yaserazfar/check_unchecked_errors

timvaillancourt · web-flow · commit f334dbde5ebb · 2020-08-14T17:03:10.000+02:00
Adds error checking for an err variable that was left unchecked
diff --git a/go/sql/builder.go b/go/sql/builder.go
@@ -492,6 +492,9 @@ func BuildDMLUpdateQuery(databaseName, tableName string, tableColumns, sharedCol
 	}
 
 	setClause, err := BuildSetPreparedClause(mappedSharedColumns)
+	if err != nil {
+		return "", sharedArgs, uniqueKeyArgs, err
+	}
 
 	equalsComparison, err := BuildEqualsPreparedComparison(uniqueKeyColumns.Names())
 	result = fmt.Sprintf(`

Original file line number	Diff line number	Diff line change
`@@ -492,6 +492,9 @@ func BuildDMLUpdateQuery(databaseName, tableName string, tableColumns, sharedCol`
`492`	`492`	`}`
`493`	`493`
`494`	`494`	`setClause, err := BuildSetPreparedClause(mappedSharedColumns)`
	`495`	`+ if err != nil {`
	`496`	`+ return "", sharedArgs, uniqueKeyArgs, err`
	`497`	`+ }`
`495`	`498`
`496`	`499`	`equalsComparison, err := BuildEqualsPreparedComparison(uniqueKeyColumns.Names())`
`497`	`500`	result = fmt.Sprintf(`