Skip to content

Commit 40bd67a

Browse files
author
Lars Schneider
committed
sizes: lower max tree entries threshold to 1000
Warn the user with one star if a tree has more than 1000 entries and warn the user with exclamation points after 30k entries. Reasons: (1) GitHub truncates directories with more than 1000 entries on the website and consequently the content would be harder to discover. (2) The default Windows file system NTFS might experience performance issues if individual directories contain more than 50k files [1]. Let's warn the user way before this known threshold. [1] https://support.microsoft.com/en-us/help/2539403/system-may-pause-while-accessing-large-ntfs-folder
1 parent 2e9a30f commit 40bd67a

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ Processing references: 539
122122
| * Maximum size [1] | 72.7 KiB | * |
123123
| * Maximum parents [2] | 66 | ****** |
124124
| * Trees | | |
125-
| * Maximum entries [3] | 1.68 k | |
125+
| * Maximum entries [3] | 1.68 k | * |
126126
| * Blobs | | |
127127
| * Maximum size [4] | 13.5 MiB | * |
128128
| | | |

sizes/output.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -369,7 +369,7 @@ func (s HistorySize) TableString(threshold Threshold, nameStyle NameStyle) strin
369369
),
370370

371371
S("Trees",
372-
I("Maximum entries", s.MaxTreeEntriesTree, s.MaxTreeEntries, counts.MetricPrefixes, " ", 2.5e3),
372+
I("Maximum entries", s.MaxTreeEntriesTree, s.MaxTreeEntries, counts.MetricPrefixes, " ", 1000),
373373
),
374374

375375
S("Blobs",

0 commit comments

Comments
 (0)